add RBAC tests for schedules on inventory and project updates #6240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanpetrello
force-pushed
the
schedule-rbac-tests
branch
from
266ed51 to
88e5518
Compare
ryanpetrello
commented
Mar 10, 2020
| assert 'POST' in options(url, user=alice).data['actions'].keys() | ||
| post(url, params, alice, expect=201) | ||
|
|
||
| # can't create a schedule on JT2 because we don't have execute rights | ||
| jt2 = JobTemplate.objects.create( |
There was a problem hiding this comment.
@AlanCoding mentioned in a prior view, explicitly testing this jt2 is sort of extraneous
kdelee
reviewed
Mar 10, 2020
ryanpetrello
force-pushed
the
schedule-rbac-tests
branch
from
88e5518 to
ad1a7fc
Compare
AlanCoding
reviewed
Mar 10, 2020
| assert 'POST' not in options(url, user=alice).data['actions'].keys() | ||
| post(url, params, alice, expect=403) | ||
|
|
||
| # use role does *not* grant the ability to schedule |
There was a problem hiding this comment.
man, that is subtle.
It would allow for creation of schedules of ad hoc commands. That's just not a thing.
There was a problem hiding this comment.
no, that's not use role, that would be ad_hoc role I was thinking of. Yeah, use is just for using in JTs.
AlanCoding
approved these changes
Mar 10, 2020
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
TheRealHaoLiu
pushed a commit
to TheRealHaoLiu/awx
that referenced
this pull request
Feb 8, 2023
[Backport 4.3] Fixes 'Not Found' error on looking up credentials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.