Show API choice field metadata more correctly for null vs ''

[jbradberry]

SUMMARY

The verbosity field for WorkflowJobTemplateNodes allows null as an option, but does not support '' getting coerced to null. We need to therefore reflect that in the empty option in the choices list provided by the API.

related #6196

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

• API

AWX VERSION

awx: 9.2.0

[softwarefactory-project-zuul]

Build succeeded.

• awx-api-lint : SUCCESS in 4m 16s
• awx-api : SUCCESS in 15m 08s
• awx-ui : SUCCESS in 11m 02s
• awx-ui-next : SUCCESS in 15m 07s
• awx-swagger : SUCCESS in 11m 20s
• awx-detect-schema-change : FAILURE in 12m 15s (non-voting)
• awx-ansible-modules : SUCCESS in 5m 10s

[squidboylan]

This works for me! I verified it in the following way:

Navigate to /api/v2/workflow_job_template_nodes/ and click the OPTIONS button and find the POST option verbosity which now has the following options:

            "verbosity": {
                "type": "choice",
                "required": false,
                "label": "Verbosity",
                "filterable": false,
                "default": null,
                "choices": [
                    [
                        null,
                        "---------"
                    ],
                    [
                        0,
                        "0 (Normal)"
                    ],
                    [
                        1,
                        "1 (Verbose)"
                    ],
                    [
                        2,
                        "2 (More Verbose)"
                    ],
                    [
                        3,
                        "3 (Debug)"
                    ],
                    [
                        4,
                        "4 (Connection Debug)"
                    ],
                    [
                        5,
                        "5 (WinRM Debug)"
                    ]
                ]
            },

Then I created a workflow job template node with verbosity=None and confirmed that the API did not send back an error code.

[softwarefactory-project-zuul]

Build succeeded (gate pipeline).

• awx-api-lint : SUCCESS in 4m 18s
• awx-api : SUCCESS in 10m 42s
• awx-ui : SUCCESS in 9m 11s
• awx-ui-next : SUCCESS in 10m 19s
• awx-swagger : SUCCESS in 13m 09s
• awx-detect-schema-change : FAILURE in 10m 19s (non-voting)
• awx-ansible-modules : SUCCESS in 4m 49s
• awx-push-new-schema : SUCCESS in 12m 53s (non-voting)