Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where Inventory Host Add form doesn't save #6187

Conversation

marshmalien
Copy link
Member

SUMMARY

#6184

This PR moves the inventory lookup field outside of HostForm to prevent Formik from hooking up to the inventory useField hook.

Discovered this was due to where we called useField because even though the inventory wasn't rendered, the formik error object contained the inventory error {inventory: "Select a value for this field"}.

Bug Recording
bug

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • UI

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@dsesami dsesami self-requested a review March 5, 2020 16:38
Copy link
Contributor

@dsesami dsesami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this fix works, and also that the separate hosts creation dialogue works fine. Edit pages also work.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b560a21 into ansible:devel Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants