Fixed form validation to JT survey minimum & maximum values #4509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed issue ansible/tower#3679 Signed-off-by: Hideki Saito <[email protected]>
|
Build succeeded.
|
saito-hideki
changed the title
jakemcdermott
approved these changes
Aug 19, 2019
There was a problem hiding this comment.
"" (empty string) can occur after clearing the field, while null occurs as a default for undefined fields when loading an existing survey.
Both states are presented identically but were handled differently by the validators. Since empty strings are already being excluded from the min / max validation checks, I think updating these validators to also exclude null is reasonable. 👍
This looks good to me, thanks @saito-hideki
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixed form validation logic to JT survey(ANSWER_TYPE:
Text,Textarea, andPassword) minimum & maximum values to be able to handle null value properly.ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION