[WIP] Migrate JT project.organization to direct org field #4338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
|
Build failed.
|
AlanCoding
force-pushed
the
jt_org
branch
2 times, most recently
from
4331dd3 to
4dc7502
Compare
|
Build succeeded.
|
|
Build succeeded.
|
|
To update status: I'm fairly confident with this in its current form, but the idea was floated to move this field to the UnifiedJob and UnifiedJobTemplate models instead. This wouldn't affect anything at the API interaction layer, unless we populated the field for other types like project update or inventory updates to be comprehensive. Then we could add the field on those models as well. |
AlanCoding
commented
Jul 23, 2019
awx/main/models/jobs.py
Outdated
| null=True, | ||
| on_delete=models.SET_NULL, | ||
| related_name='%(class)ss', | ||
| ) |
There was a problem hiding this comment.
Discussed with @chrismeyersfsu, considering making this a field on the UnifiedJob and UnifiedJobTemplate models instead. That will involve more migration work, but will be much more performant.
AlanCoding
changed the title
|
Marking as WIP until I can come back to that point. |
AlanCoding
force-pushed
the
jt_org
branch
2 times, most recently
from
fcd206d to
28ec83d
Compare
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build succeeded.
|
|
The form of this has changed so much that I will open up a new PR after the details have been nailed down - with the primary difference being that this would not become a user-editable field. |
This was referenced Sep 6, 2019
ryanpetrello
pushed a commit
to ryanpetrello/awx
that referenced
this pull request
Aug 5, 2020
[3.7.1] Fixes bug where all_parents_must_converge was not being set for new or existing approval nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Connect #3903
Also addresses #4008
ISSUE TYPE
COMPONENT NAME
AWX VERSION