Code

Workflow Approval Nodes#4264

Code

Merged

softwarefactory-project-zuul[bot] merged 58 commits intoansible:develansible/awx:develfrom beeankha:workflow_pause_approvebeeankha/awx:workflow_pause_approveCopy head branch name to clipboardAug 28, 2019

+3,177-1,806

Commits

Commits on Aug 27, 2019

• Add workflow pause/approve node

  

  beeankha

  authored and

  ryanpetrello

  committed
  b88b111

  Copy full SHA for b88b111

• Add migration file

  

  beeankha

  authored and

  ryanpetrello

  committed
  72a65f7

  Copy full SHA for 72a65f7

• Add API endpoints for workflow approvals

  

  beeankha

  authored and

  ryanpetrello

  committed
  9024a51

  Copy full SHA for 9024a51

• Clean up redundancies

  

  beeankha

  authored and

  ryanpetrello

  committed
  d76e912

  Copy full SHA for d76e912

• Add approve/deny endpoints, fix some typos

  

  beeankha

  authored and

  ryanpetrello

  committed
  82e0b21

  Copy full SHA for 82e0b21

• Add initial support for workflow pause approve

  

  mabashian

  authored and

  ryanpetrello

  committed
  0720857

  Copy full SHA for 0720857

• Fix linting error

  

  mabashian

  authored and

  ryanpetrello

  committed
  1d814be

  Copy full SHA for 1d814be

• Approval drawer cleanup and workflow node form UX cleanup

  

  mabashian

  authored and

  ryanpetrello

  committed
  e0cdc4f

  Copy full SHA for e0cdc4f

• Fix jshint errors

  

  mabashian

  authored and

  ryanpetrello

  committed
  83f9681

  Copy full SHA for 83f9681

• Add new endpoint for creation of approval nodes

  

  beeankha

  authored and

  ryanpetrello

  committed
  3202842

  Copy full SHA for 3202842

• Polishing up work on new endpoint

  

  beeankha

  authored and

  ryanpetrello

  committed
  294d655

  Copy full SHA for 294d655

• Cleanup and changes to the way approval templates are created

  

  mabashian

  authored and

  ryanpetrello

  committed
  4a801c6

  Copy full SHA for 4a801c6

• Fix error related to workflow_approval_templates/N endpoint

  

  beeankha

  authored and

  ryanpetrello

  committed
  24c5404

  Copy full SHA for 24c5404

• Fix UJT-related error, add notification placeholders

  

  beeankha

  authored and

  ryanpetrello

  committed
  453e142

  Copy full SHA for 453e142

• Add more RBAC, filter out AJT/AJs from unified jobs lists

  Show description for 64c94d4
  

  beeankha

  authored and

  ryanpetrello

  committed
  64c94d4

  Copy full SHA for 64c94d4

• Enable deletion of orphaned approval nodes

  Show description for 3357c96
  

  beeankha

  authored and

  ryanpetrello

  committed
  3357c96

  Copy full SHA for 3357c96

• Prompt bug cleanup. Filter workflow_approval jobs out of jobs list. Add initial support for timeout.

  

  mabashian

  authored and

  ryanpetrello

  committed
  013792f

  Copy full SHA for 013792f

• Cleanup a few jshint errors

  

  mabashian

  authored and

  ryanpetrello

  committed
  630f428

  Copy full SHA for 630f428

• Add more RBAC for approval nodes

  

  beeankha

  authored and

  ryanpetrello

  committed
  296b4e8

  Copy full SHA for 296b4e8

• Clean up RBAC code

  

  beeankha

  authored and

  ryanpetrello

  committed
  5f82754

  Copy full SHA for 5f82754

• Add timeout for workflow approval nodes

  

  beeankha

  authored and

  ryanpetrello

  committed
  28289e8

  Copy full SHA for 28289e8

• fixed a few issues related to approval role RBAC for normal users

  ryanpetrello

  committed
  0522d45

  Copy full SHA for 0522d45

• Activity stream and timeout

  Show description for 8c17990
  

  beeankha

  authored and

  ryanpetrello

  committed
  8c17990

  Copy full SHA for 8c17990

• Update timeout implementation, placeholder code for possible websocket support

  

  beeankha

  authored and

  ryanpetrello

  committed
  544a506

  Copy full SHA for 544a506

• Update UJ/UJT endpoints, update approval RBAC, update approval timeout

  

  beeankha

  authored and

  ryanpetrello

  committed
  d9f3fed

  Copy full SHA for d9f3fed

• fix a few nits w/ workflow approval activity stream records

  ryanpetrello

  committed
  4a75edf

  Copy full SHA for 4a75edf

• when copying workflows w/ pause nodes, copy the WorkflowApprovalTemplate

  ryanpetrello

  committed
  7814592

  Copy full SHA for 7814592

• Update websockets for pending approvals, change timeout expiration to

  

  beeankha

  authored and

  ryanpetrello

  committed
  f6f6e58

  Copy full SHA for f6f6e58

• Update summary field for activity stream

  

  beeankha

  authored and

  ryanpetrello

  committed
  9186cb2

  Copy full SHA for 9186cb2

• Timeout, socket and activity stream changes for workflow pause approve

  

  mabashian

  authored and

  ryanpetrello

  committed
  adf621d

  Copy full SHA for adf621d

• Add approval node logic to awxkit

  Show description for bdf4def
  

  kdelee

  authored and

  ryanpetrello

  committed
  bdf4def

  Copy full SHA for bdf4def

• fix jshint errors

  

  mabashian

  authored and

  ryanpetrello

  committed
  73485b2

  Copy full SHA for 73485b2

• allow org/WF admins to create approval templates

  ryanpetrello

  committed
  761dad0

  Copy full SHA for 761dad0

• Emit approve/deny status for websockets, update doc string + a comment

  

  beeankha

  authored and

  ryanpetrello

  committed
  f7d6f45

  Copy full SHA for f7d6f45

• Update RBAC for adding approval nodes

  

  beeankha

  authored and

  ryanpetrello

  committed
  cf436ee

  Copy full SHA for cf436ee

• Rename workflow approval migration. Add approval option back to workflow node form.

  

  mabashian

  authored and

  ryanpetrello

  committed
  aac8c9f

  Copy full SHA for aac8c9f

• change up a few activity stream and approval drawer issues

  ryanpetrello

  committed
  dd89e46

  Copy full SHA for dd89e46

• Fix flake8 errors, update doc strings, ...

  Show description for 667fce5
  

  beeankha

  authored and

  ryanpetrello

  committed
  667fce5

  Copy full SHA for 667fce5

• Fix accidental deletions, update docstrings...

  Show description for aab04bc
  

  beeankha

  authored and

  ryanpetrello

  committed
  aab04bc

  Copy full SHA for aab04bc

• Update AWX docs to include info about wf approvals

  

  beeankha

  authored and

  ryanpetrello

  committed
  9bbc14c

  Copy full SHA for 9bbc14c

• Add timed out text to workflow job node. Change timeout to minutes and seconds.

  Show description for 5fc3b2c
  

  mabashian

  authored and

  ryanpetrello

  committed
  5fc3b2c

  Copy full SHA for 5fc3b2c

• Various bug fixes and minor ux enhancements

  

  mabashian

  authored and

  ryanpetrello

  committed
  3fa9497

  Copy full SHA for 3fa9497

• Fix bug in Activity Stream, add tests.

  

  beeankha

  authored and

  ryanpetrello

  committed
  582bbda

  Copy full SHA for 582bbda

• Update/add more functional tests

  

  beeankha

  authored and

  ryanpetrello

  committed
  8b23ff7

  Copy full SHA for 8b23ff7

• Add test for approve node denial

  

  beeankha

  authored and

  ryanpetrello

  committed
  b5c0f58

  Copy full SHA for b5c0f58

• Edit minor typo

  

  beeankha

  authored and

  ryanpetrello

  committed
  703de8f

  Copy full SHA for 703de8f

• Fix loading pending approval count on login

  

  mabashian

  authored and

  ryanpetrello

  committed
  9f03074

  Copy full SHA for 9f03074

• Addressing comments, updating tests, etc.

  

  beeankha

  authored and

  ryanpetrello

  committed
  ea509f5

  Copy full SHA for ea509f5

• Set view's permission classes to be more explicit

  

  beeankha

  authored and

  ryanpetrello

  committed
  b281979

  Copy full SHA for b281979

• Minor change to fix rebase conflict.

  

  beeankha

  authored and

  ryanpetrello

  committed
  2e58a47

  Copy full SHA for 2e58a47

• Fix 500 error on workflow_approvals endpoint

  

  beeankha

  authored and

  ryanpetrello

  committed
  459012e

  Copy full SHA for 459012e

• add approval timeout to the summary fields for WorkflowJobTemplateNodes

  ryanpetrello

  committed
  1eeab7e

  Copy full SHA for 1eeab7e

• Update timeout info on AWX docs.

  

  beeankha

  authored and

  ryanpetrello

  committed
  2ac1c3d

  Copy full SHA for 2ac1c3d

• update migration numbering for WF approval

  ryanpetrello

  committed
  b9f75ec

  Copy full SHA for b9f75ec

• fix a bug introduced in rebase

  ryanpetrello

  committed
  23f75cf

  Copy full SHA for 23f75cf

Commits on Aug 28, 2019

• Fix flake8 error

  beeankha

  committed
  073f6db

  Copy full SHA for 073f6db

• Styles cleanup

  mabashian

  committed
  f229418

  Copy full SHA for f229418

• Merge pull request #14 from mabashian/workflow_pause_approve_cleanup_5

  Show description for 97d9c26
  beeankha

  authored
  97d9c26

  Copy full SHA for 97d9c26