-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove oauth provider #15588
base: devel
Are you sure you want to change the base?
Remove oauth provider #15588
Conversation
Shouldn't we also modify references of OAuth usage inside the |
Docs will definitely need to be changed. #15554 should have fixed the collection to allow basic auth. I'm still working through test failures, though, so there may be further changes needed. |
f847bdc
to
adcf3bd
Compare
4bfc6a3
to
37ecb0a
Compare
b1f2579
to
8d91fe6
Compare
I reviewed with an eye towards migrations. If we missed some code to delete or deleted too much we can fix that easily. An error is in the data is harder to retroactivity fix. I found changes in the activity stream entries. I don't think I care. Activity StreamSteps to Recreate
I'll note how those activity stream entries change because of this PR. App Creation - Before
App Creation - After
Token Creation - Before
Token Creation - After
Application Edit - Before
Application Edit - After
Token edit before/after is also effected in the same way. ThoughtsThe migrations in this PR change the activity stream entries. Specifically, the deletion of the application and/or token can cause the We recommend that customers and users hook up external logging to their splunk/grafana-thing/elk to track these sorts of things long-term, so I guess it's OK that our activity stream entries change. |
Unblocked now, because #15647 is merged |
This removes the oauth provider functionality from awx. The oauth2_provider app and all references to it have been removed. Migrations to delete the two tables that locally overwrote oauth2_provider tables are included. This change does not include migrations to delete the tables provided by the oauth2_provider app. Also not included here are changes to awxkit, awx_collection or the ui.
The changes in ansible#15554 will cause a few collection tests to fail, depending on what the test configuration is. This changes the tests to look for a specific warning rather than counting the number of warnings emitted.
8d91fe6
to
0341aba
Compare
Quality Gate passedIssues Measures |
@@ -0,0 +1,39 @@ | |||
# Generated by Django 4.2.10 on 2024-10-24 14:06 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This migration file should be renamed to the obvious like "remove oauth2 models"
SUMMARY
This removes the oauth provider functionality from awx. The oauth2_provider app and all references to it have been removed. Migrations to delete the two tables that locally overwrote oauth2_provider tables are included. This change does not include migrations to delete the tables provided by the oauth2_provider app.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION