[RBAC] Fix bug where team could not be given read_role to other team #15067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabloHiro
approved these changes
Apr 5, 2024
PabloHiro
requested changes
Apr 5, 2024
|
This should be in better shape now, but awaiting results. |
|
Updated results look good |
fosterseth
reviewed
Apr 5, 2024
fosterseth
approved these changes
Apr 5, 2024
from Seth in review comment Co-authored-by: Seth Foster <[email protected]>
PabloHiro
pushed a commit
that referenced
this pull request
Apr 8, 2024
…15067) * Fix bug where team could not be given read_role to other team * Avoid unwanted triggers of parentage granting * Restructure signal structure * Fix another bug unmasked by team member permission fix * Changes to live with test writing * Use equality as opposed to string "in" from Seth in review comment Co-authored-by: Seth Foster <[email protected]> --------- Co-authored-by: Seth Foster <[email protected]>
PabloHiro
pushed a commit
that referenced
this pull request
Apr 9, 2024
…15067) * Fix bug where team could not be given read_role to other team * Avoid unwanted triggers of parentage granting * Restructure signal structure * Fix another bug unmasked by team member permission fix * Changes to live with test writing * Use equality as opposed to string "in" from Seth in review comment Co-authored-by: Seth Foster <[email protected]> --------- Co-authored-by: Seth Foster <[email protected]>
AlanCoding
added a commit
that referenced
this pull request
Apr 10, 2024
…15067) * Fix bug where team could not be given read_role to other team * Avoid unwanted triggers of parentage granting * Restructure signal structure * Fix another bug unmasked by team member permission fix * Changes to live with test writing * Use equality as opposed to string "in" from Seth in review comment Co-authored-by: Seth Foster <[email protected]> --------- Co-authored-by: Seth Foster <[email protected]>
AlanCoding
added a commit
that referenced
this pull request
Apr 10, 2024
…15067) * Fix bug where team could not be given read_role to other team * Avoid unwanted triggers of parentage granting * Restructure signal structure * Fix another bug unmasked by team member permission fix * Changes to live with test writing * Use equality as opposed to string "in" from Seth in review comment Co-authored-by: Seth Foster <[email protected]> --------- Co-authored-by: Seth Foster <[email protected]>
AlanCoding
added a commit
that referenced
this pull request
Apr 11, 2024
…15067) * Fix bug where team could not be given read_role to other team * Avoid unwanted triggers of parentage granting * Restructure signal structure * Fix another bug unmasked by team member permission fix * Changes to live with test writing * Use equality as opposed to string "in" from Seth in review comment Co-authored-by: Seth Foster <[email protected]> --------- Co-authored-by: Seth Foster <[email protected]>
AlanCoding
added a commit
that referenced
this pull request
Apr 11, 2024
…15067) * Fix bug where team could not be given read_role to other team * Avoid unwanted triggers of parentage granting * Restructure signal structure * Fix another bug unmasked by team member permission fix * Changes to live with test writing * Use equality as opposed to string "in" from Seth in review comment Co-authored-by: Seth Foster <[email protected]> --------- Co-authored-by: Seth Foster <[email protected]>
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
…nsible#15067) * Fix bug where team could not be given read_role to other team * Avoid unwanted triggers of parentage granting * Restructure signal structure * Fix another bug unmasked by team member permission fix * Changes to live with test writing * Use equality as opposed to string "in" from Seth in review comment Co-authored-by: Seth Foster <[email protected]> --------- Co-authored-by: Seth Foster <[email protected]>
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Nov 11, 2024
…nsible#15067) * Fix bug where team could not be given read_role to other team * Avoid unwanted triggers of parentage granting * Restructure signal structure * Fix another bug unmasked by team member permission fix * Changes to live with test writing * Use equality as opposed to string "in" from Seth in review comment Co-authored-by: Seth Foster <[email protected]> --------- Co-authored-by: Seth Foster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I tracked down this bug as the source of some failures we were seeing. Steps were:
The bug is that the user could not see the child team at the end of these steps. This was a bug strictly with the translation layer. The team-to-team permission was applied in the old roles, but not applied in the DAB RBAC system because the m2m_changed signal we relied on to relay this change was considering this to be a parent addition we should ignore.
ISSUE TYPE
COMPONENT NAME