Fix missing role membership when giving creator permissions #15058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checks will fail until supporting DAB change is merged. |
fosterseth
approved these changes
Apr 2, 2024
PabloHiro
approved these changes
Apr 3, 2024
AlanCoding
added a commit
that referenced
this pull request
Apr 3, 2024
PabloHiro
pushed a commit
that referenced
this pull request
Apr 8, 2024
PabloHiro
pushed a commit
that referenced
this pull request
Apr 9, 2024
AlanCoding
added a commit
that referenced
this pull request
Apr 10, 2024
AlanCoding
added a commit
that referenced
this pull request
Apr 10, 2024
AlanCoding
added a commit
that referenced
this pull request
Apr 11, 2024
AlanCoding
added a commit
that referenced
this pull request
Apr 11, 2024
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes a bug discovered by QE.
We sync role memberships only 1 way, if you use the old API then the new API is changed to reflect the permission setup. However, the same is not true the other way around (and may be un-representable) for memberships... it is for access in a weird nuance.
By using the new
give_creator_permissionsfrom the DAB library, this did not add the user in question to the memberships of the old role. It is valid to say that this fails to conform to the existing role API contract.This needs a supporting DAB change ansible/django-ansible-base#253
ISSUE TYPE
COMPONENT NAME