Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DOCKER_COMPOSE command to docker compose #15056

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Update DOCKER_COMPOSE command to docker compose #15056

merged 2 commits into from
Apr 2, 2024

Conversation

TheRealHaoLiu
Copy link
Member

SUMMARY

docker-compose will stop being supported soon and this is causing CI flake setting DOCKER_COMPOSE default to docker compose

example failure https://github.com/ansible/awx/actions/runs/8513225204/job/23358409052?pr=15053

make[1]: Entering directory '/home/runner/work/awx/awx'
docker-compose -f tools/docker-compose/_sources/docker-compose.yml  up -d --remove-orphans
bash: line 1: docker-compose: command not found
make[1]: *** [Makefile:550: docker-compose-up] Error 127
make[1]: Leaving directory '/home/runner/work/awx/awx'
make: *** [Makefile:543: docker-compose] Error 2
Error: Process completed with exit code 2.
ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Other
AWX VERSION
ADDITIONAL INFORMATION

@TheRealHaoLiu
Update DOCKER_COMPOSE command
ab995f3 
docker-compose will stop being supported soon and this is causing CI flake setting DOCKER_COMPOSE default to `docker compose`
@TheRealHaoLiu TheRealHaoLiu mentioned this pull request Apr 2, 2024
Closed
@TheRealHaoLiu TheRealHaoLiu merged commit 7cdf1c7 into ansible:devel Apr 2, 2024
21 checks passed
@TheRealHaoLiu TheRealHaoLiu deleted the docker-compose-default-update branch April 2, 2024 19:13
djyasin pushed a commit to djyasin/awx that referenced this pull request Sep 16, 2024
@TheRealHaoLiu @djyasin
Update DOCKER_COMPOSE command to docker compose (ansible#15056)
6ea8ab2 
* Update DOCKER_COMPOSE command

docker-compose will stop being supported soon and this is causing CI flake setting DOCKER_COMPOSE default to `docker compose`

* Give AWX network a static name
djyasin pushed a commit to djyasin/awx that referenced this pull request Nov 11, 2024
@TheRealHaoLiu @djyasin
Update DOCKER_COMPOSE command to docker compose (ansible#15056)
f546eaf 
* Update DOCKER_COMPOSE command

docker-compose will stop being supported soon and this is causing CI flake setting DOCKER_COMPOSE default to `docker compose`

* Give AWX network a static name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanCoding AlanCoding AlanCoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheRealHaoLiu @AlanCoding