Support Google credentials on Terraform credentials type #15055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abikouo
force-pushed
the
tf_credential_gce
branch
from
3560842
to
de915b4
Compare
chrismeyersfsu
approved these changes
Apr 3, 2024
|
Hey @abikouo this PR looks good, but there is a failing test. Can you have a look at it and fix it up? |
@chrismeyersfsu I am currently trying to fix tests. Thanks |
abikouo
force-pushed
the
tf_credential_gce
branch
from
de915b4
to
d3d4245
Compare
github-actions
bot
added
component:awx_collection
abikouo
force-pushed
the
tf_credential_gce
branch
2 times, most recently
from
8235416
to
9b619df
Compare
|
@chrismeyersfsu the tests have been fixed, for the |
abikouo
force-pushed
the
tf_credential_gce
branch
3 times, most recently
from
c6d8d0f
to
8091c75
Compare
abikouo
force-pushed
the
tf_credential_gce
branch
from
8091c75
to
6184b92
Compare
|
@chrismeyersfsu CI is ok now, could you please merge this? |
thedoubl3j
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Looks good and looks like CI is happy now, @chrismeyersfsu you mind finishing you review and merging.
chrismeyersfsu
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Terraform configuration for gcs backend requires a path to a credentials file. It is not possible to combine credentials in an inventory source, so there needs to be a way to get the credentials file for GCE into the Terraform credential plugin.
This PR add a new attribute to the Terraform credential plugin which allows to push GCE credentials file.
ISSUE TYPE
COMPONENT NAME
Terraform backend configuration Secret management
AWX VERSION
ADDITIONAL INFORMATION