Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make db password optional for wsrelay #15046

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

TheRealHaoLiu
Copy link
Member

SUMMARY

follow up to https://github.com/ansible/awx/pull/14820/files

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API
AWX VERSION

ADDITIONAL INFORMATION

@TheRealHaoLiu TheRealHaoLiu force-pushed the wsrelay-db-passwordless branch from 9f148c1 to b47dac9 Compare March 28, 2024 19:55
@TheRealHaoLiu TheRealHaoLiu marked this pull request as draft March 28, 2024 19:59
@TheRealHaoLiu TheRealHaoLiu force-pushed the wsrelay-db-passwordless branch from b47dac9 to 6577053 Compare March 28, 2024 20:05
@TheRealHaoLiu TheRealHaoLiu marked this pull request as ready for review March 28, 2024 20:40
Copy link
Member

@AlanCoding AlanCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like to see deepcopy, but if there really is a copy/pop bug that existed, that would be fairly high priority. I see this also makes changes unrelated to that (extending the patch to wsrelay) and that is perfectly valid. No hazards obvious, so shipit.

@TheRealHaoLiu TheRealHaoLiu merged commit d558204 into ansible:devel Apr 2, 2024
21 checks passed
@TheRealHaoLiu TheRealHaoLiu deleted the wsrelay-db-passwordless branch April 2, 2024 15:47
djyasin pushed a commit to djyasin/awx that referenced this pull request Sep 16, 2024
* Make db password optional for wsrelay

* Change DB setting copy to deepcopy

safer than copy()

Co-Authored-By: Jeff Bradberry <[email protected]>

---------

Co-authored-by: Jeff Bradberry <[email protected]>
djyasin pushed a commit to djyasin/awx that referenced this pull request Nov 11, 2024
* Make db password optional for wsrelay

* Change DB setting copy to deepcopy

safer than copy()

Co-Authored-By: Jeff Bradberry <[email protected]>

---------

Co-authored-by: Jeff Bradberry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants