-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RBAC] Fix server error from delete capability of approvals #15002
Merged
AlanCoding
merged 1 commit into
ansible:feature_dab_rbac
from
AlanCoding:approval_node_fix
Mar 15, 2024
Merged
[RBAC] Fix server error from delete capability of approvals #15002
AlanCoding
merged 1 commit into
ansible:feature_dab_rbac
from
AlanCoding:approval_node_fix
Mar 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccahhh
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, that is a skeleton. Appropriate workaround without a huge overhaul +1
AlanCoding
added a commit
that referenced
this pull request
Mar 19, 2024
Fix server error from delete capability of approvals
AlanCoding
added a commit
that referenced
this pull request
Apr 2, 2024
Fix server error from delete capability of approvals
AlanCoding
added a commit
that referenced
this pull request
Apr 3, 2024
Fix server error from delete capability of approvals
PabloHiro
pushed a commit
that referenced
this pull request
Apr 8, 2024
Fix server error from delete capability of approvals
PabloHiro
pushed a commit
that referenced
this pull request
Apr 9, 2024
Fix server error from delete capability of approvals
AlanCoding
added a commit
that referenced
this pull request
Apr 10, 2024
Fix server error from delete capability of approvals
AlanCoding
added a commit
that referenced
this pull request
Apr 10, 2024
Fix server error from delete capability of approvals
AlanCoding
added a commit
that referenced
this pull request
Apr 11, 2024
Fix server error from delete capability of approvals
AlanCoding
added a commit
that referenced
this pull request
Apr 11, 2024
Fix server error from delete capability of approvals
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
…15002) Fix server error from delete capability of approvals
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Nov 11, 2024
…15002) Fix server error from delete capability of approvals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Now this is a skeleton that adding validation managed to dig up. Look at
WorkflowApprovalAccess
, it never wrote CRUD access logic... and this model doesn't have roles either.So it deferred to BaseAccess. What does that mean? Edit / other stuff is restricted to superuser. Okay, but the view probably doesn't allow this anyway, right? Nope, it does. Didn't make sense then, still doesn't make sense. I'm just trying to fix the server error.
ISSUE TYPE
COMPONENT NAME