Use AWX base view to make unauth requests 401 #14981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbradberry
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Wholeheartedly endorsed.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/403
|
The integration tests are looking good for this, so merging. |
AlanCoding
added a commit
that referenced
this pull request
Mar 14, 2024
AlanCoding
added a commit
that referenced
this pull request
Mar 19, 2024
AlanCoding
added a commit
that referenced
this pull request
Apr 2, 2024
AlanCoding
added a commit
that referenced
this pull request
Apr 3, 2024
PabloHiro
pushed a commit
that referenced
this pull request
Apr 8, 2024
PabloHiro
pushed a commit
that referenced
this pull request
Apr 9, 2024
AlanCoding
added a commit
that referenced
this pull request
Apr 10, 2024
AlanCoding
added a commit
that referenced
this pull request
Apr 10, 2024
AlanCoding
added a commit
that referenced
this pull request
Apr 11, 2024
AlanCoding
added a commit
that referenced
this pull request
Apr 11, 2024
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is needed to fix "crawler" test failures, where 403 responses are given to unauthenticated users and 401 is expected.
See AWX
get_authenticate_headermethod.ALSO - note that without that method override
https://github.com/encode/django-rest-framework/blob/09a0c551ca934e486d2765e042a287c15fa85e75/rest_framework/views.py#L190
DRF uses
and in my case, this was
AwxJWTAuthentication, which came from the DRF base class, which gave nothing, which became a 403. This is violently unstable, and will afflict other apps.ISSUE TYPE
COMPONENT NAME