allow pytest --migrations to succeed #14663
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| from django.db import migrations | ||
|
|
||
|
|
||
| class RunSQL(migrations.operations.special.RunSQL): | ||
| """ | ||
| Bit of a hack here. Django actually wants this decision made in the router | ||
| and we can pass **hints. | ||
| """ | ||
|
|
||
| def __init__(self, *args, **kwargs): | ||
| if 'sqlite_sql' not in kwargs: | ||
| raise ValueError("sqlite_sql parameter required") | ||
| sqlite_sql = kwargs.pop('sqlite_sql') | ||
|
|
||
| self.sqlite_sql = sqlite_sql | ||
| self.sqlite_reverse_sql = kwargs.pop('sqlite_reverse_sql', None) | ||
| super().__init__(*args, **kwargs) | ||
|
|
||
| def database_forwards(self, app_label, schema_editor, from_state, to_state): | ||
| if not schema_editor.connection.vendor.startswith('postgres'): | ||
| self.sql = self.sqlite_sql or migrations.RunSQL.noop | ||
| super().database_forwards(app_label, schema_editor, from_state, to_state) | ||
|
|
||
| def database_backwards(self, app_label, schema_editor, from_state, to_state): | ||
| if not schema_editor.connection.vendor.startswith('postgres'): | ||
| self.reverse_sql = self.sqlite_reverse_sql or migrations.RunSQL.noop | ||
| super().database_backwards(app_label, schema_editor, from_state, to_state) | ||
|
|
||
|
|
||
| class RunPython(migrations.operations.special.RunPython): | ||
| """ | ||
| Bit of a hack here. Django actually wants this decision made in the router | ||
| and we can pass **hints. | ||
| """ | ||
|
|
||
| def __init__(self, *args, **kwargs): | ||
| if 'sqlite_code' not in kwargs: | ||
| raise ValueError("sqlite_code parameter required") | ||
| sqlite_code = kwargs.pop('sqlite_code') | ||
|
|
||
| self.sqlite_code = sqlite_code | ||
| self.sqlite_reverse_code = kwargs.pop('sqlite_reverse_code', None) | ||
| super().__init__(*args, **kwargs) | ||
|
|
||
| def database_forwards(self, app_label, schema_editor, from_state, to_state): | ||
| if not schema_editor.connection.vendor.startswith('postgres'): | ||
| self.code = self.sqlite_code or migrations.RunPython.noop | ||
|
There was a problem hiding this comment. I don't love this behavior. One point, months ago, I did the same thing you did here - made the migrations compatible with sqlite3. But for the life of me I can not find the branch where I worked on that. I just added a condition in the migration logic depending on the vendor, and that didn't take as many changes as you could think. Sure there are lots of logic steps we just don't want to run, but doing this I expect we're going to miss some stuff we should have, like creating default system jobs, or creating default credential types. Also the naming of There was a problem hiding this comment. I don't follow. Do you not like that the user can supply I'm fine with renaming There was a problem hiding this comment. Talked with @AlanCoding offline. TL;DR |
||
| super().database_forwards(app_label, schema_editor, from_state, to_state) | ||
|
|
||
| def database_backwards(self, app_label, schema_editor, from_state, to_state): | ||
| if not schema_editor.connection.vendor.startswith('postgres'): | ||
| self.reverse_code = self.sqlite_reverse_code or migrations.RunPython.noop | ||
| super().database_backwards(app_label, schema_editor, from_state, to_state) | ||
|
|
||
|
|
||
| class _sqlitemigrations: | ||
| RunPython = RunPython | ||
| RunSQL = RunSQL | ||
|
|
||
|
|
||
| dbawaremigrations = _sqlitemigrations() | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still got a TODO here. Why? Are you really going to migrate event data? I see no way you will get the hourly event tables to work in sqlite3. Of course it doesn't support range partitioning from the get-go, but even if you created superficial "partitions" as separate tables, I'm skeptical that it could be made to work, or that it would be worth it if you could do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is for the BigInt migration. I'm sure we won't ever want to do this in sqlite3. The next file does migration to partitions, which again, may be feasible superficially, but questionable value.