Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch nginx worker process to auto #1251

Closed
wants to merge 1 commit into from

Conversation

matburt
Copy link
Member

@matburt matburt commented Feb 14, 2018

This uses some internal logic from nginx to determine the optimal
number of worker processes given the available number of cores (and
some other details).

This might help busier systems.

This uses some internal logic from nginx to determine the optimal
number of worker processes given the available number of cores (and
some other details).

This might help busier systems.
@shanemcd
Copy link
Member

Concern I raised to @matburt:

I’m wondering what would happen if you’re running in a container on a Kubernetes node that has 16 cores. But you limit the pod to only 10% of the CPU cycles. Is it going to create 16 worker processes and then they’re constantly fighting each other?

@wenottingham
Copy link
Contributor

@shanemcd probably depends on what your container runtime mounts as its /proc or /sys vis-a-vis cgroups/namespaces

@shanemcd
Copy link
Member

shanemcd commented Feb 20, 2018

Regarding the concern I raised: nginxinc/docker-nginx#31

Edit: The official nginx images hardcode 1: https://github.com/nginxinc/docker-nginx/blob/master/stable/alpine/nginx.conf#L3

@matburt matburt closed this Feb 20, 2018
chrismeyersfsu pushed a commit to chrismeyersfsu/awx that referenced this pull request Apr 26, 2018
Set `raw=True` when reading passwords from ConfigParser files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants