Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWX_TASK_ENV is read-only in the base image #1315

Closed
ryanpetrello opened this issue Feb 21, 2018 · 4 comments
Closed

AWX_TASK_ENV is read-only in the base image #1315

ryanpetrello opened this issue Feb 21, 2018 · 4 comments
Labels
component:api component:installer type:bug

Comments

@ryanpetrello
Copy link
Contributor

ryanpetrello commented Feb 21, 2018 •
edited
Loading

https://github.com/ansible/awx/blame/6163cc6b5c3a3c8f5bd173d121cafd15c5b75b17/installer/image_build/files/settings.py#L26 is set statically in the base image, and that makes the setting read-only from the Settings API. We should come up with a way to set this value at install time that doesn't require setting the value in settings.py (via either an API call or via awx-manage shell).
@ryanpetrello
Copy link
Contributor Author

related: #490 (comment)

@wenottingham
Copy link
Contributor

Shouldn't that come from the user's homedir anyway?

@ryanpetrello
Copy link
Contributor Author

ryanpetrello commented Feb 21, 2018 •
edited
Loading

@wenottingham that was my thought, but @shanemcd tinkered and without https://github.com/ansible/awx/blame/6163cc6b5c3a3c8f5bd173d121cafd15c5b75b17/installer/image_build/files/settings.py#L26, $HOME doesn't seem to be set. So there must be a reason why we set this manually...

@ryanpetrello
Copy link
Contributor Author

ryanpetrello commented Feb 22, 2018 •
edited
Loading

Looking into this more, awx and prod Tower installs don't set HOME explicitly via AWX_TASK_ENV, so I'm still stumped as to why this is necessary. Going to spin up minishift install without this line and see if I can troubleshoot.

@ryanpetrello ryanpetrello mentioned this issue Feb 26, 2018
Merged
ryanpetrello added a commit to ryanpetrello/awx that referenced this issue Feb 26, 2018
@ryanpetrello
set HOME via an API call so AWX_TASK_ENV isn't marked as readonly
14ea5f0 
see: ansible#1315
ryanpetrello added a commit to ryanpetrello/awx that referenced this issue Feb 26, 2018
@ryanpetrello
set $HOME via an API call so AWX_TASK_ENV isn't marked as readonly
7741de5 
see: ansible#1315
chrismeyersfsu pushed a commit to chrismeyersfsu/awx that referenced this issue Apr 26, 2018
@mabashian
Merge pull request ansible#1315 from mabashian/1004-smart-inv-hosts
5959c01 
Force on/off toggle to be disabled on smart inventory host list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:api component:installer type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ryanpetrello @jlaska @wenottingham