installer: nginx: add missing locales location required by ui_next #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinuscosinustan
changed the title
sinuscosinustan
force-pushed
the
ts-fix-locales
branch
3 times, most recently
from
703b007 to
83f3d86
Compare
The new UI depends on the locales available via ingress/locales which is being served as static file and not via Django. A change in the nginx.conf was already done for the dev environment in commit ec4f10d86881389af12371f90cb75af03417d109 (AWX), but not here. Signed-off-by: Tom Siewert <[email protected]>
sinuscosinustan
force-pushed
the
ts-fix-locales
branch
from
83f3d86 to
9891866
Compare
|
@rooftopcellist PR Check failed with |
rooftopcellist
approved these changes
May 1, 2024
|
@tomsiewert Thanks for the PR! Yes, CI was complaining because it expects 3 categories, the entire category is I edited the description, it should pass now, I'll merge shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The new UI depends on the locales available via ingress/locales which is being served as static file and not via Django.
A change in the nginx.conf was already done for the dev environment in commit ec4f10d86881389af12371f90cb75af03417d109 (AWX), but not here.
ISSUE TYPE