Enable configuration of rsyslog environmental variables, volume mounts, and entrypoints #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All credits goes to @rooftopcellist , we just need this PR ASAP. |
rooftopcellist
force-pushed
the
rsyslog-vars-volumes
branch
from
99f4b50 to
dab7396
Compare
|
@ubajze Thank you for your help completing these changes! Sorry for the wait here, I just rebased this PR. Once the tests finish, I plan to merge it. |
rooftopcellist
approved these changes
Jun 30, 2023
|
@rooftopcellist any chance to release 2.3.1 for this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR finishes what was started by @rooftopcellist in the PR #1423
ISSUE TYPE
ADDITIONAL INFORMATION
Fixes #1409