Updated task.yaml.j2 rsyslog container to have preStop hook #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing pre-stop hook on rsyslog in the task pod
|
@rooftopcellist and @TheRealHaoLiu When you have some time can you folks look into this PR.Appreciate in advance |
fosterseth
reviewed
May 24, 2023
|
@TheRealHaoLiu @stanislav-zaprudskiy any feedback ? |
Co-authored-by: Stanislav Zaprudskiy <[email protected]>
|
Applied the suggested changes |
fosterseth
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Updated task.yaml.j2 rsyslog container to have preStop hook
ISSUE TYPE
ADDITIONAL INFORMATION
This addresses missing pre-stop hook on rsyslog in the task pod and rsyslog container will terminate when terminationGracePeriod happens.
This will address hopefully following issue #1383