Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add startupProbe for web #1125

Closed
wants to merge 1 commit into from
Closed

Conversation

chris93111
Copy link
Contributor

SUMMARY

Wen controlplane scale the container is go to ready fastly and the web/api is not ready, so client has 503 response

The startupProbe allows to protect time for starting web/api in autoscale scenario

ISSUE TYPE

503 in autoscale scenario

ADDITIONAL INFORMATION

Maybe the value of failureThreshold is incorrect, the django migration can put more time in update or initial scenario

@chris93111
Copy link
Contributor Author

any update ?

@fosterseth
Copy link
Member

@chris93111 do you mind rebasing and resolving the conflicts? the deployment is now split into web and task

@chris93111
Copy link
Contributor Author

@chris93111 do you mind rebasing and resolving the conflicts? the deployment is now split into web and task

Ok

@chris93111 chris93111 reopened this Oct 25, 2023
@chris93111
Copy link
Contributor Author

chris93111 commented Oct 25, 2023

Hi @fosterseth

sorry for the time

rebase and conflicts resolved

readiness add to web deployment

@rooftopcellist
Copy link
Member

@chris93111 Is there a specific reason why we would want a startupProbe here rather than intialDelaySeconds on a readinessProbe?

FYI, there is a PR here for adding the readiness and liveliness probes that is actively being reviewed as well:

@rooftopcellist
Copy link
Member

This feature has been merged as part of #1674. It is not technically a startupProbe, but serves the same purpose as a readinessProbe. If this does not resolve your issue, please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants