Added pg_dump_suffix doc and crd property #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let add a known working example of the parameter? You encountered some special formatting upon table-data exclusion? |
|
LGTM! |
|
@dsavineau / @CFSNM ? or other maintainers available to check this out? |
|
@MathijsVanWilligen Could you please rebase this? Sorry for the delay, we are going through old PR's and this looks like a good candidate for merge. |
Signed-off-by: Mathijs van Willigen <[email protected]>
Signed-off-by: Mathijs van Willigen <[email protected]>
|
Hi @rooftopcellist, thanks for your reply. I have rebased my branch onto awx-operator/devel. |
|
FYI to anyone wondering, this PR is follow-up for this other PR which introduced the pg_dump_suffix variable: Thanks for making this configurable via the AWX spec @MathijsVanWilligen ! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #958
SUMMARY
Add documentation for the 'pg_dump_suffix' parameter.
Also add this option to the awxbackup crd properties so it can be used inside the crd. Without a definition inside the crd we won't be able to use the 'pg_dump_suffix' parameter.
ISSUE TYPE