fix: reduce duplicated code blocks by templates

roles/installer/templates/common/volume_mounts/extra_settings_files.yaml.j2

@@ -0,0 +1,16 @@
+{% if extra_settings_files.configmaps is defined and extra_settings_files.configmaps | length %}
+{% for configmap in extra_settings_files.configmaps %}
+- name: {{ ansible_operator_meta.name }}-{{ configmap.key | replace('_', '-') | replace('.', '-') | lower }}-configmap
+  mountPath: "/etc/tower/conf.d/{{ configmap.key }}"
+  subPath: {{ configmap.key }}
+  readOnly: true
+{% endfor %}
+{% endif %}
+{% if extra_settings_files.secrets is defined and extra_settings_files.secrets | length %}
+{% for secret in extra_settings_files.secrets %}
+- name: {{ ansible_operator_meta.name }}-{{ secret.key | replace('_', '-') | replace('.', '-') | lower }}-secret
+  mountPath: "/etc/tower/conf.d/{{ secret.key }}"
+  subPath: {{ secret.key }}
+  readOnly: true
+{% endfor %}
+{% endif %}

roles/installer/templates/common/volumes/extra_settings_files.yaml.j2

@@ -0,0 +1,20 @@
+{% if extra_settings_files.configmaps is defined and extra_settings_files.configmaps | length %}
+{% for configmap in extra_settings_files.configmaps %}
+- name: {{ ansible_operator_meta.name }}-{{ configmap.key | replace('_', '-') | replace('.', '-') | lower }}-configmap
+  configMap:
+    name: {{ configmap.name }}
+    items:
+      - key: {{ configmap.key }}
+        path: {{ configmap.key }}
+{% endfor %}
+{% endif %}
+{% if extra_settings_files.secrets is defined and extra_settings_files.secrets | length %}
+{% for secret in extra_settings_files.secrets %}
+- name: {{ ansible_operator_meta.name }}-{{ secret.key | replace('_', '-') | replace('.', '-') | lower }}-secret
+  secret:
+    secretName: {{ secret.name }}
+    items:
+      - key: {{ secret.key }}
+        path: {{ secret.key }}
+{% endfor %}
+{% endif %}

roles/installer/templates/cronjobs/metrics-utility-gather.yaml.j2

@@ -63,22 +63,7 @@ spec:
               mountPath: /etc/tower/settings.py
               subPath: settings.py
               readOnly: true
-{% if extra_settings_files.configmaps is defined and extra_settings_files.configmaps | length %}
-{% for configmap in extra_settings_files.configmaps %}
-            - name: {{ ansible_operator_meta.name }}-{{ configmap.key | replace('_', '-') | replace('.', '-') | lower }}-configmap
-              mountPath: "/etc/tower/conf.d/{{ configmap.key }}"
-              subPath: {{ configmap.key }}
-              readOnly: true
-{% endfor %}
-{% endif %}
-{% if extra_settings_files.secrets is defined and extra_settings_files.secrets | length %}
-{% for secret in extra_settings_files.secrets %}
-            - name: {{ ansible_operator_meta.name }}-{{ secret.key | replace('_', '-') | replace('.', '-') | lower }}-secret
-              mountPath: "/etc/tower/conf.d/{{ secret.key }}"
-              subPath: {{ secret.key }}
-              readOnly: true
-{% endfor %}
-{% endif %}
+            {{ lookup("template", "common/volume_mounts/extra_settings_files.yaml.j2")  | indent(width=12) | trim }}
           volumes:
           - name: {{ ansible_operator_meta.name }}-metrics-utility
             persistentVolumeClaim:
@@ -96,24 +81,5 @@ spec:
               items:
                 - key: settings
                   path: settings.py
-{% if extra_settings_files.configmaps is defined and extra_settings_files.configmaps | length %}
-{% for configmap in extra_settings_files.configmaps %}
-          - name: {{ ansible_operator_meta.name }}-{{ configmap.key | replace('_', '-') | replace('.', '-') | lower }}-configmap
-            configMap:
-              name: {{ configmap.name }}
-              items:
-                - key: {{ configmap.key }}
-                  path: {{ configmap.key }}
-{% endfor %}
-{% endif %}
-{% if extra_settings_files.secrets is defined and extra_settings_files.secrets | length %}
-{% for secret in extra_settings_files.secrets %}
-          - name: {{ ansible_operator_meta.name }}-{{ secret.key | replace('_', '-') | replace('.', '-') | lower }}-secret
-            secret:
-              secretName: {{ secret.name }}
-              items:
-                - key: {{ secret.key }}
-                  path: {{ secret.key }}
-{% endfor %}
-{% endif %}
+          {{ lookup("template", "common/volumes/extra_settings_files.yaml.j2")  | indent(width=10) | trim }}
           restartPolicy: OnFailure

roles/installer/templates/cronjobs/metrics-utility-report.yaml.j2

@@ -60,22 +60,7 @@ spec:
               mountPath: /etc/tower/settings.py
               subPath: settings.py
               readOnly: true
-{% if extra_settings_files.configmaps is defined and extra_settings_files.configmaps | length %}
-{% for configmap in extra_settings_files.configmaps %}
-            - name: {{ ansible_operator_meta.name }}-{{ configmap.key | replace('_', '-') | replace('.', '-') | lower }}-configmap
-              mountPath: "/etc/tower/conf.d/{{ configmap.key }}"
-              subPath: {{ configmap.key }}
-              readOnly: true
-{% endfor %}
-{% endif %}
-{% if extra_settings_files.secrets is defined and extra_settings_files.secrets | length %}
-{% for secret in extra_settings_files.secrets %}
-            - name: {{ ansible_operator_meta.name }}-{{ secret.key | replace('_', '-') | replace('.', '-') | lower }}-secret
-              mountPath: "/etc/tower/conf.d/{{ secret.key }}"
-              subPath: {{ secret.key }}
-              readOnly: true
-{% endfor %}
-{% endif %}
+            {{ lookup("template", "common/volume_mounts/extra_settings_files.yaml.j2")  | indent(width=12) | trim }}
           volumes:
           - name: {{ ansible_operator_meta.name }}-metrics-utility
             persistentVolumeClaim:
@@ -93,24 +78,5 @@ spec:
               items:
                 - key: settings
                   path: settings.py
-{% if extra_settings_files.configmaps is defined and extra_settings_files.configmaps | length %}
-{% for configmap in extra_settings_files.configmaps %}
-          - name: {{ ansible_operator_meta.name }}-{{ configmap.key | replace('_', '-') | replace('.', '-') | lower }}-configmap
-            configMap:
-              name: {{ configmap.name }}
-              items:
-                - key: {{ configmap.key }}
-                  path: {{ configmap.key }}
-{% endfor %}
-{% endif %}
-{% if extra_settings_files.secrets is defined and extra_settings_files.secrets | length %}
-{% for secret in extra_settings_files.secrets %}
-          - name: {{ ansible_operator_meta.name }}-{{ secret.key | replace('_', '-') | replace('.', '-') | lower }}-secret
-            secret:
-              secretName: {{ secret.name }}
-              items:
-                - key: {{ secret.key }}
-                  path: {{ secret.key }}
-{% endfor %}
-{% endif %}
+          {{ lookup("template", "common/volumes/extra_settings_files.yaml.j2")  | indent(width=10) | trim }}
           restartPolicy: OnFailure

roles/installer/templates/deployments/task.yaml.j2

@@ -95,22 +95,7 @@ spec:
               mountPath: "/etc/tower/settings.py"
               subPath: settings.py
               readOnly: true
-{% if extra_settings_files.configmaps is defined and extra_settings_files.configmaps | length %}
-{% for configmap in extra_settings_files.configmaps %}
-            - name: {{ ansible_operator_meta.name }}-{{ configmap.key | replace('_', '-') | replace('.', '-') | lower }}-configmap
-              mountPath: "/etc/tower/conf.d/{{ configmap.key }}"
-              subPath: {{ configmap.key }}
-              readOnly: true
-{% endfor %}
-{% endif %}
-{% if extra_settings_files.secrets is defined and extra_settings_files.secrets | length %}
-{% for secret in extra_settings_files.secrets %}
-            - name: {{ ansible_operator_meta.name }}-{{ secret.key | replace('_', '-') | replace('.', '-') | lower }}-secret
-              mountPath: "/etc/tower/conf.d/{{ secret.key }}"
-              subPath: {{ secret.key }}
-              readOnly: true
-{% endfor %}
-{% endif %}
+            {{ lookup("template", "common/volume_mounts/extra_settings_files.yaml.j2")  | indent(width=12) | trim }}
 {% if development_mode | bool %}
             - name: awx-devel
               mountPath: "/awx_devel"
@@ -295,22 +280,7 @@ spec:
               mountPath: /etc/tower/settings.py
               subPath: settings.py
               readOnly: true
-{% if extra_settings_files.configmaps is defined and extra_settings_files.configmaps | length %}
-{% for configmap in extra_settings_files.configmaps %}
-            - name: {{ ansible_operator_meta.name }}-{{ configmap.key | replace('_', '-') | replace('.', '-') | lower }}-configmap
-              mountPath: "/etc/tower/conf.d/{{ configmap.key }}"
-              subPath: {{ configmap.key }}
-              readOnly: true
-{% endfor %}
-{% endif %}
-{% if extra_settings_files.secrets is defined and extra_settings_files.secrets | length %}
-{% for secret in extra_settings_files.secrets %}
-            - name: {{ ansible_operator_meta.name }}-{{ secret.key | replace('_', '-') | replace('.', '-') | lower }}-secret
-              mountPath: "/etc/tower/conf.d/{{ secret.key }}"
-              subPath: {{ secret.key }}
-              readOnly: true
-{% endfor %}
-{% endif %}
+            {{ lookup("template", "common/volume_mounts/extra_settings_files.yaml.j2")  | indent(width=12) | trim }}
             - name: {{ ansible_operator_meta.name }}-redis-socket
               mountPath: "/var/run/redis"
             - name: rsyslog-socket
@@ -460,22 +430,7 @@ spec:
               mountPath: "/etc/tower/settings.py"
               subPath: settings.py
               readOnly: true
-{% if extra_settings_files.configmaps is defined and extra_settings_files.configmaps | length %}
-{% for configmap in extra_settings_files.configmaps %}
-            - name: {{ ansible_operator_meta.name }}-{{ configmap.key | replace('_', '-') | replace('.', '-') | lower }}-configmap
-              mountPath: "/etc/tower/conf.d/{{ configmap.key }}"
-              subPath: {{ configmap.key }}
-              readOnly: true
-{% endfor %}
-{% endif %}
-{% if extra_settings_files.secrets is defined and extra_settings_files.secrets | length %}
-{% for secret in extra_settings_files.secrets %}
-            - name: {{ ansible_operator_meta.name }}-{{ secret.key | replace('_', '-') | replace('.', '-') | lower }}-secret
-              mountPath: "/etc/tower/conf.d/{{ secret.key }}"
-              subPath: {{ secret.key }}
-              readOnly: true
-{% endfor %}
-{% endif %}
+            {{ lookup("template", "common/volume_mounts/extra_settings_files.yaml.j2")  | indent(width=12) | trim }}
             - name: {{ ansible_operator_meta.name }}-redis-socket
               mountPath: "/var/run/redis"
             - name: rsyslog-socket
@@ -636,26 +591,7 @@ spec:
             items:
               - key: redis_conf
                 path: redis.conf
-{% if extra_settings_files.configmaps is defined and extra_settings_files.configmaps | length %}
-{% for configmap in extra_settings_files.configmaps %}
-        - name: {{ ansible_operator_meta.name }}-{{ configmap.key | replace('_', '-') | replace('.', '-') | lower }}-configmap
-          configMap:
-            name: {{ configmap.name }}
-            items:
-              - key: {{ configmap.key }}
-                path: {{ configmap.key }}
-{% endfor %}
-{% endif %}
-{% if extra_settings_files.secrets is defined and extra_settings_files.secrets | length %}
-{% for secret in extra_settings_files.secrets %}
-        - name: {{ ansible_operator_meta.name }}-{{ secret.key | replace('_', '-') | replace('.', '-') | lower }}-secret
-          secret:
-            secretName: {{ secret.name }}
-            items:
-              - key: {{ secret.key }}
-                path: {{ secret.key }}
-{% endfor %}
-{% endif %}
+        {{ lookup("template", "common/volumes/extra_settings_files.yaml.j2")  | indent(width=8) | trim }}
         - name: {{ ansible_operator_meta.name }}-redis-socket
           emptyDir: {}
         - name: {{ ansible_operator_meta.name }}-redis-data

roles/installer/templates/deployments/web.yaml.j2

@@ -231,22 +231,7 @@ spec:
               mountPath: /etc/tower/settings.py
               subPath: settings.py
               readOnly: true
-{% if extra_settings_files.configmaps is defined and extra_settings_files.configmaps | length %}
-{% for configmap in extra_settings_files.configmaps %}
-            - name: {{ ansible_operator_meta.name }}-{{ configmap.key | replace('_', '-') | replace('.', '-') | lower }}-configmap
-              mountPath: "/etc/tower/conf.d/{{ configmap.key }}"
-              subPath: {{ configmap.key }}
-              readOnly: true
-{% endfor %}
-{% endif %}
-{% if extra_settings_files.secrets is defined and extra_settings_files.secrets | length %}
-{% for secret in extra_settings_files.secrets %}
-            - name: {{ ansible_operator_meta.name }}-{{ secret.key | replace('_', '-') | replace('.', '-') | lower }}-secret
-              mountPath: "/etc/tower/conf.d/{{ secret.key }}"
-              subPath: {{ secret.key }}
-              readOnly: true
-{% endfor %}
-{% endif %}
+            {{ lookup("template", "common/volume_mounts/extra_settings_files.yaml.j2")  | indent(width=12) | trim }}
             - name: {{ ansible_operator_meta.name }}-nginx-conf
               mountPath: /etc/nginx/nginx.conf
               subPath: nginx.conf
@@ -323,22 +308,7 @@ spec:
               mountPath: "/etc/tower/settings.py"
               subPath: settings.py
               readOnly: true
-{% if extra_settings_files.configmaps is defined and extra_settings_files.configmaps | length %}
-{% for configmap in extra_settings_files.configmaps %}
-            - name: {{ ansible_operator_meta.name }}-{{ configmap.key | replace('_', '-') | replace('.', '-') | lower }}-configmap
-              mountPath: "/etc/tower/conf.d/{{ configmap.key }}"
-              subPath: {{ configmap.key }}
-              readOnly: true
-{% endfor %}
-{% endif %}
-{% if extra_settings_files.secrets is defined and extra_settings_files.secrets | length %}
-{% for secret in extra_settings_files.secrets %}
-            - name: {{ ansible_operator_meta.name }}-{{ secret.key | replace('_', '-') | replace('.', '-') | lower }}-secret
-              mountPath: "/etc/tower/conf.d/{{ secret.key }}"
-              subPath: {{ secret.key }}
-              readOnly: true
-{% endfor %}
-{% endif %}
+            {{ lookup("template", "common/volume_mounts/extra_settings_files.yaml.j2")  | indent(width=12) | trim }}
             - name: {{ ansible_operator_meta.name }}-redis-socket
               mountPath: "/var/run/redis"
             - name: rsyslog-socket
@@ -470,26 +440,7 @@ spec:
             items:
               - key: redis_conf
                 path: redis.conf
-{% if extra_settings_files.configmaps is defined and extra_settings_files.configmaps | length %}
-{% for configmap in extra_settings_files.configmaps %}
-        - name: {{ ansible_operator_meta.name }}-{{ configmap.key | replace('_', '-') | replace('.', '-') | lower }}-configmap
-          configMap:
-            name: {{ configmap.name }}
-            items:
-              - key: {{ configmap.key }}
-                path: {{ configmap.key }}
-{% endfor %}
-{% endif %}
-{% if extra_settings_files.secrets is defined and extra_settings_files.secrets | length %}
-{% for secret in extra_settings_files.secrets %}
-        - name: {{ ansible_operator_meta.name }}-{{ secret.key | replace('_', '-') | replace('.', '-') | lower }}-secret
-          secret:
-            secretName: {{ secret.name }}
-            items:
-              - key: {{ secret.key }}
-                path: {{ secret.key }}
-{% endfor %}
-{% endif %}
+        {{ lookup("template", "common/volumes/extra_settings_files.yaml.j2")  | indent(width=8) | trim }}
         - name: {{ ansible_operator_meta.name }}-uwsgi-config
           configMap:
             name: {{ ansible_operator_meta.name }}-{{ deployment_type }}-configmap

roles/installer/templates/jobs/migration.yaml.j2

@@ -29,22 +29,7 @@ spec:
               mountPath: "/etc/tower/settings.py"
               subPath: settings.py
               readOnly: true
-{% if extra_settings_files.configmaps is defined and extra_settings_files.configmaps | length %}
-{% for configmap in extra_settings_files.configmaps %}
-            - name: {{ ansible_operator_meta.name }}-{{ configmap.key | replace('_', '-') | replace('.', '-') | lower }}-configmap
-              mountPath: "/etc/tower/conf.d/{{ configmap.key }}"
-              subPath: {{ configmap.key }}
-              readOnly: true
-{% endfor %}
-{% endif %}
-{% if extra_settings_files.secrets is defined and extra_settings_files.secrets | length %}
-{% for secret in extra_settings_files.secrets %}
-            - name: {{ ansible_operator_meta.name }}-{{ secret.key | replace('_', '-') | replace('.', '-') | lower }}-secret
-              mountPath: "/etc/tower/conf.d/{{ secret.key }}"
-              subPath: {{ secret.key }}
-              readOnly: true
-{% endfor %}
-{% endif %}
+            {{ lookup("template", "common/volume_mounts/extra_settings_files.yaml.j2")  | indent(width=12) | trim }}
 {% if development_mode | bool %}
             - name: awx-devel
               mountPath: "/awx_devel"
@@ -82,26 +67,7 @@ spec:
             items:
               - key: settings
                 path: settings.py
-{% if extra_settings_files.configmaps is defined and extra_settings_files.configmaps | length %}
-{% for configmap in extra_settings_files.configmaps %}
-        - name: {{ ansible_operator_meta.name }}-{{ configmap.key | replace('_', '-') | replace('.', '-') | lower }}-configmap
-          configMap:
-            name: {{ configmap.name }}
-            items:
-              - key: {{ configmap.key }}
-                path: {{ configmap.key }}
-{% endfor %}
-{% endif %}
-{% if extra_settings_files.secrets is defined and extra_settings_files.secrets | length %}
-{% for secret in extra_settings_files.secrets %}
-        - name: {{ ansible_operator_meta.name }}-{{ secret.key | replace('_', '-') | replace('.', '-') | lower }}-secret
-          secret:
-            secretName: {{ secret.name }}
-            items:
-              - key: {{ secret.key }}
-                path: {{ secret.key }}
-{% endfor %}
-{% endif %}
+        {{ lookup("template", "common/volumes/extra_settings_files.yaml.j2")  | indent(width=8) | trim }}
 {% if development_mode | bool %}
         - name: awx-devel
           hostPath: