Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Override RAW attributes #75

Merged
merged 1 commit into from
Feb 23, 2017
Merged

Conversation

syncrou
Copy link
Contributor

@syncrou syncrou commented Feb 23, 2017

the HashModel rewrites integer based attributes into attribute_id. This PR rewrites the raw values returned from
an API response into the correct '_id' style

https://www.pivotaltracker.com/story/show/140521307

@syncrou
Copy link
Contributor Author

syncrou commented Feb 23, 2017

@bdunne - See what you think - This solves my current update_attributes problem

@syncrou
Copy link
Contributor Author

syncrou commented Feb 23, 2017

@miq-bot add_label bug

@miq-bot assign @bdunne

the  rewrites integer based attributes into attribute_id. This PR rewrites the raw values returned from
an API response into the correct '_id' style

https://www.pivotaltracker.com/story/show/140521307
@syncrou syncrou force-pushed the override_raw_attributes branch from 986fb1d to ef521ad Compare February 23, 2017 22:03
@miq-bot
Copy link
Collaborator

miq-bot commented Feb 23, 2017

Checked commit syncrou@ef521ad with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks good. 👍

@bdunne
Copy link
Contributor

bdunne commented Feb 23, 2017

Merging for now until I can finish up the reverse translation work I started on today.

@bdunne bdunne merged commit c9e742f into ansible:master Feb 23, 2017
@syncrou syncrou deleted the override_raw_attributes branch February 23, 2017 23:08
d-m-u added a commit to d-m-u/ansible_tower_client_ruby that referenced this pull request Jun 29, 2020
more core ext's on 4.1.0

update for update sake

https://github.com/ManageIQ/more_core_extensions/compare/179bf40..e5b4501
 - Added Ruby 2.7 support [[ansible#79](ManageIQ/more_core_extensions#79)]
 - Added Process#pause, Process#resume, and Process#alive? [[ansible#73](ManageIQ/more_core_extensions#73)]

array added * `#compact_map` - Collect non-nil results from the block
array added `#tabular_sort` - Sorts an Array of Hashes by specific columns

hierarchy added `#descendant_get` - Returns the descendant with a given name

the two breaking changes:
- **BREAKING**: Moved Object#descendant_get to Class#descendant_get [[ansible#75](ManageIQ/more_core_extensions#75)]
- **BREAKING**: Removed deprecated Enumerable#stable_sort_by [[ansible#76](ManageIQ/more_core_extensions#76)]

a minor header output change was made that hasn't been released yet to make tableize more markdown compliant

see ManageIQ/linux_admin#221
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants