Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

add activity stream as an api method #54

Merged
merged 1 commit into from
Jan 12, 2017

Conversation

durandom
Copy link
Contributor

@durandom durandom commented Jan 9, 2017

also adds ability to pass down options to collections

@durandom durandom changed the title [WIP] add activity stream as an api method add activity stream as an api method Jan 10, 2017
@durandom
Copy link
Contributor Author

@miq-bot assign @bdunne @syncrou

@bdunne @syncrou please review

@miq-bot
Copy link
Collaborator

miq-bot commented Jan 10, 2017

@durandom @bdunne @syncrou is an invalid assignee, ignoring...

Copy link
Contributor

@syncrou syncrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@durandom - The Activity stream addition (itself) looks good - though I think I would rather see the options change in Collection.rb as a separate PR.

@durandom
Copy link
Contributor Author

@syncrou extracted to #57

@miq-bot
Copy link
Collaborator

miq-bot commented Jan 11, 2017

Checked commit durandom@b8b04e0 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
4 files checked, 0 offenses detected
Everything looks good. 🍰

let(:raw_url_collection) { build(:response_url_collection, :klass => described_class, :url => url) }
let(:raw_instance) { build(:response_instance, :group, :klass => described_class) }

include_examples "Collection Methods"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shared example "Crud Methods" could be included in here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid this endpoint only allows GET, HEAD, OPTIONS per
https://ansible_tower3/api/v1/activity_stream/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can split the "Crud Methods" shared example into multiple shared examples (Create, Update, Delete, etc.).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ansible/ansible_tower_client_ruby/blob/master/spec/support/shared_examples/crud_methods.rb only has an example for 'POST'

Do you want shared examples for read in this PR? I'd rather like to do it in follow up, as I need this to move further for the event catcher in miq

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are not 'POST'ing to this endpoint, we can deal with it later.

@syncrou
Copy link
Contributor

syncrou commented Jan 12, 2017

👍 LGTM

@bdunne bdunne merged commit 7d76cf6 into ansible:master Jan 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants