-
Notifications
You must be signed in to change notification settings - Fork 41
workflow_job_template and workflow_job_template_node #104
Conversation
@bdunne can you take a look first? (specs are still being worked on) |
8762ae8
to
d33a9be
Compare
spec/collection_spec.rb
Outdated
@@ -10,6 +10,8 @@ | |||
AnsibleTowerClient::Job, | |||
AnsibleTowerClient::JobEvent, | |||
AnsibleTowerClient::JobTemplate, | |||
AnsibleTowerClient::WorkflowJob, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these be alphabetical?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't WorkflowJobTemplateNode
be listed here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
spec/support/mock_api.rb
Outdated
@@ -32,6 +32,10 @@ def get(path, get_options = nil) | |||
wrap_response(Job.response) | |||
when "job_templates" | |||
wrap_response(JobTemplate.response) | |||
when "workflow_job_template_nodes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, can these be alphabetical?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
"workflow_job_template": "/api/v1/workflow_job_templates/298/" | ||
}, | ||
"summary_fields": { | ||
"workflow_job_template": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there's some indentation issue in this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Some comments on commits jameswnl/ansible_tower_client_ruby@867c5d3~...e4e5685 spec/workflow_job_template_spec.rb
|
Checked commits jameswnl/ansible_tower_client_ruby@867c5d3~...e4e5685 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 spec/support/mock_api/workflow_job_template.rb
|
...continued
spec/support/mock_api/workflow_job_template_node.rb
|
...continued
|
...continued
|
https://bugzilla.redhat.com/show_bug.cgi?id=1468339
Part of ManageIQ/manageiq#17441