Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

workflow_job_template and workflow_job_template_node #104

Merged
merged 4 commits into from
Jun 4, 2018

Conversation

jameswnl
Copy link
Contributor

@jameswnl jameswnl commented May 18, 2018

@jameswnl
Copy link
Contributor Author

@bdunne can you take a look first? (specs are still being worked on)

@jameswnl jameswnl changed the title [WIP] workflow_job_template and workflow_job workflow_job_template and workflow_job Jun 1, 2018
@jameswnl jameswnl changed the title workflow_job_template and workflow_job workflow_job_template and workflow_job_template_node Jun 1, 2018
@jameswnl
Copy link
Contributor Author

jameswnl commented Jun 1, 2018

@miq-bot remove_label wip
@miq-bot add_label enhancement

@miq-bot miq-bot added enhancement and removed wip labels Jun 1, 2018
@jameswnl jameswnl force-pushed the workflow branch 2 times, most recently from 8762ae8 to d33a9be Compare June 1, 2018 22:52
@jameswnl
Copy link
Contributor Author

jameswnl commented Jun 1, 2018

@miq-bot assign @bdunne

@jameswnl
Copy link
Contributor Author

jameswnl commented Jun 1, 2018

@miq-bot add_reviewer @bdunne

@miq-bot miq-bot requested a review from bdunne June 1, 2018 23:00
@@ -10,6 +10,8 @@
AnsibleTowerClient::Job,
AnsibleTowerClient::JobEvent,
AnsibleTowerClient::JobTemplate,
AnsibleTowerClient::WorkflowJob,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these be alphabetical?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't WorkflowJobTemplateNode be listed here too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -32,6 +32,10 @@ def get(path, get_options = nil)
wrap_response(Job.response)
when "job_templates"
wrap_response(JobTemplate.response)
when "workflow_job_template_nodes"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can these be alphabetical?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"workflow_job_template": "/api/v1/workflow_job_templates/298/"
},
"summary_fields": {
"workflow_job_template": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's some indentation issue in this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@miq-bot
Copy link
Collaborator

miq-bot commented Jun 4, 2018

Some comments on commits jameswnl/ansible_tower_client_ruby@867c5d3~...e4e5685

spec/workflow_job_template_spec.rb

  • ⚠️ - 18 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

@miq-bot
Copy link
Collaborator

miq-bot commented Jun 4, 2018

Checked commits jameswnl/ansible_tower_client_ruby@867c5d3~...e4e5685 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
12 files checked, 753 offenses detected

spec/support/mock_api/workflow_job_template.rb

@miq-bot
Copy link
Collaborator

miq-bot commented Jun 4, 2018

...continued

spec/support/mock_api/workflow_job_template_node.rb

@miq-bot
Copy link
Collaborator

miq-bot commented Jun 4, 2018

...continued

@miq-bot
Copy link
Collaborator

miq-bot commented Jun 4, 2018

...continued

@bdunne bdunne merged commit 44d95ec into ansible:master Jun 4, 2018
@jameswnl jameswnl deleted the workflow branch June 8, 2018 15:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants