-
Notifications
You must be signed in to change notification settings - Fork 23.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[security] Add no_log to several module args (CVE-2021-20191) [2.8] #73488
Merged
relrod
merged 3 commits into
ansible:stable-2.8
from
relrod:backport/2.8/modules/several-nolog-fixes
Feb 5, 2021
Merged
[security] Add no_log to several module args (CVE-2021-20191) [2.8] #73488
relrod
merged 3 commits into
ansible:stable-2.8
from
relrod:backport/2.8/modules/several-nolog-fixes
Feb 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change: - A number of modules were missing no_log=True where they should have had it. Test Plan: - Lots of grepping.
@relrod, just so you are aware we have a dedicated Working Group for network. |
ansibot
added
affects_2.8
This issue/PR affects Ansible v2.8
backport
This PR does not target the devel branch.
bug
This issue/PR relates to a bug.
cisco
Cisco technologies
cloud
collection
Related to Ansible Collections work
collection:cisco.nxos
collection:community.docker
collection:community.general
collection:community.network
collection:google.cloud
collection:netapp.elementsw
community_review
In order to be merged, this PR must follow the community review workflow.
deprecated
This issue/PR relates to a deprecated module.
docker
gce
huawei
Huawei community
module
This issue/PR relates to a module.
needs_triage
Needs a first human triage before being processed.
netapp
networking
Network category
nxos
Cisco NXOS community
storage
support:community
This issue/PR relates to code supported by the Ansible community.
web_infrastructure
Web-infrastructure category
labels
Feb 4, 2021
The test
|
ansibot
added
ci_verified
Changes made in this PR are causing tests to fail.
and removed
community_review
In order to be merged, this PR must follow the community review workflow.
labels
Feb 4, 2021
ansibot
added
the
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
label
Feb 4, 2021
Signed-off-by: Rick Elrod <[email protected]>
…al#1725 Signed-off-by: Rick Elrod <[email protected]>
ansibot
added
core_review
In order to be merged, this PR must follow the core review workflow.
gitlab
Gitlab community
infoblox
Infoblox NIOS
monitoring
Monitoring category
net_tools
Net-tools category
packaging
Packaging category
source_control
Source-control category
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
and removed
ci_verified
Changes made in this PR are causing tests to fail.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
Feb 4, 2021
sivel
removed
the
needs_triage
Needs a first human triage before being processed.
label
Feb 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.8
This issue/PR affects Ansible v2.8
backport
This PR does not target the devel branch.
bug
This issue/PR relates to a bug.
cisco
Cisco technologies
cloud
collection:cisco.nxos
collection:community.docker
collection:community.general
collection:community.network
collection:google.cloud
collection:netapp.elementsw
collection
Related to Ansible Collections work
core_review
In order to be merged, this PR must follow the core review workflow.
deprecated
This issue/PR relates to a deprecated module.
docker
gce
gitlab
Gitlab community
huawei
Huawei community
infoblox
Infoblox NIOS
module
This issue/PR relates to a module.
monitoring
Monitoring category
net_tools
Net-tools category
netapp
networking
Network category
nxos
Cisco NXOS community
packaging
Packaging category
source_control
Source-control category
storage
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
web_infrastructure
Web-infrastructure category
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Change:
had it.
Test Plan:
ISSUE TYPE
COMPONENT NAME
modules