Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_updates: Add flag to only download updates without installing them #58631

Merged
merged 5 commits into from
Aug 27, 2019
Merged

win_updates: Add flag to only download updates without installing them #58631

merged 5 commits into from
Aug 27, 2019

Conversation

Ruben-Bosch
Copy link
Contributor

SUMMARY

Download win_updates only.
For some use cases (low bandwidth, etc), it can be desirable to create a play which only (searches and) downloads the Windows updates. Where a later play only installs them. This saves time for our precious and relatively small maintenance windows.

Like the 'state: searched' feature, this is mainly a premature exit, since the module currently searches, downloads, installs and reboots.
Caveat: changed is True whenever there are updates available, which are at this point already downloaded. Running the module twice, will return changed=True, even when no new updates have physically been downloaded.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

modules/win_updates

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jul 2, 2019

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Jul 2, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 2, 2019

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/windows/win_updates.py:190:1: W293 blank line contains whitespace
lib/ansible/modules/windows/win_updates.py:193:15: W291 trailing whitespace

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 2, 2019
@samdoran samdoran added the ci_verified Changes made in this PR are causing tests to fail. label Jul 2, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 2, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 3, 2019
@Ruben-Bosch Ruben-Bosch marked this pull request as ready for review July 3, 2019 10:51
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 3, 2019
@Ruben-Bosch Ruben-Bosch closed this Jul 3, 2019
@Ruben-Bosch Ruben-Bosch reopened this Jul 3, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 3, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 11, 2019
Copy link
Contributor

@jborean93 jborean93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took so long for the review, changes look good to me

@jborean93
Copy link
Contributor

rebuild_merge

@ansibot ansibot added has_issue shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Aug 27, 2019
@jborean93
Copy link
Contributor

Unstable tests are unrelated, merging in.

@jborean93 jborean93 merged commit 5549788 into ansible:devel Aug 27, 2019
@Ruben-Bosch Ruben-Bosch deleted the feature_win_update_download_only branch August 28, 2019 08:28
adharshsrivatsr pushed a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
ansible#58631)

* win_updates: Add flag to only download updates without installing them

* Fix test

* Fixes ansible-test (pep8)

* Fix integration test

* Fix actual fix.
anas-shami pushed a commit to anas-shami/ansible that referenced this pull request Sep 23, 2019
ansible#58631)

* win_updates: Add flag to only download updates without installing them

* Fix test

* Fixes ansible-test (pep8)

* Fix integration test

* Fix actual fix.
@ansible ansible locked and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 feature This issue/PR relates to a feature request. has_issue module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. shipit This PR is ready to be merged by Core support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants