Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_psmodule - Missing SkipPublisherCheck in Prerq installations #58090

Merged
merged 4 commits into from
Jul 4, 2019
Merged

win_psmodule - Missing SkipPublisherCheck in Prerq installations #58090

merged 4 commits into from
Jul 4, 2019

Conversation

ShachafGoldstein
Copy link
Contributor

SUMMARY

Fixes: #58088

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_psmodule.ps1

ADDITIONAL INFORMATION

@ShachafGoldstein ShachafGoldstein mentioned this pull request Jun 19, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented Jun 19, 2019

cc @if-meaton @jborean93 @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Jun 19, 2019
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jun 20, 2019
@ansibot ansibot added the owner_pr This PR is made by the module's maintainer. label Jun 28, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 1, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 2, 2019

The test ansible-test sanity --test pslint [explain] failed with 1 error:

lib/ansible/modules/windows/win_psmodule.ps1:81:1: PSAvoidTrailingWhitespace Line has trailing whitespace

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Jul 2, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jul 2, 2019
@jborean93 jborean93 merged commit 6e319ff into ansible:devel Jul 4, 2019
@ShachafGoldstein ShachafGoldstein deleted the 58088 branch July 4, 2019 22:56
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jhawkesworth jhawkesworth jhawkesworth left review comments

@jborean93 jborean93 jborean93 approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

win_psmodule fails due to a prerequisite PowerShellGet module conflict
5 participants
@ShachafGoldstein @ansibot @jhawkesworth @jborean93 @bcoca