Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_acl: fix recent bug and add basic tests #43054

Merged
merged 1 commit into from
Jul 22, 2018

Conversation

jborean93
Copy link
Contributor

SUMMARY

Recent commit broke win_acl if inherit was not specified. This fixes that issue and adds some basic tests to hopefully catch some of these issues.

Fixes #43049

No need to backport as this bug is only in the devel branch.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_acl

ANSIBLE VERSION
devel

@ansibot
Copy link
Contributor

ansibot commented Jul 20, 2018

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community labels Jul 20, 2018
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Jul 20, 2018
@jborean93 jborean93 merged commit 64f5f9c into ansible:devel Jul 22, 2018
@jborean93 jborean93 deleted the win_acl-fix branch July 22, 2018 19:16
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

win_acl enumeration issues for InheritanceFlags
3 participants