Teach 'make rpm' to work on EL5 based systems #2362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 11, 2013 15:31
Only the nosetests aren't using the PYTHON variable now.
mpdehaan
added a commit
that referenced
this pull request
Mar 11, 2013
Teach 'make rpm' to work on EL5 based systems
|
merged, thanks! |
robinro
pushed a commit
to robinro/ansible
that referenced
this pull request
Dec 9, 2016
travis: workaround false negative test failure
robinro
pushed a commit
to robinro/ansible
that referenced
this pull request
Dec 9, 2016
This reverts commit d056879.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming python26 and friends are installed, teach the makefile to spit out an RPM. This set of changes has been tested on SL5 and SL6 it spits out an rpm and seems to do the right thing the systems we have here. I would suggest someone test this before pulling, especially as I do not use the fireball mode. Please test!
Also, this depends on #2361 I thought it might be better to have two separate PR's as you might not want the packaging changes.