Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{amazon,community}.aws: cross-project testing #1357

Merged
merged 1 commit into from
Feb 21, 2022
Merged

{amazon,community}.aws: cross-project testing #1357

merged 1 commit into from
Feb 21, 2022

Conversation

goneri
Copy link
Collaborator

@goneri goneri commented Feb 15, 2022

If there is a change in module_utils, run the CI only for the modules
affected by that change.
This also solves the case where in the same PR there is a change in a
module_utils file (e.g., rds) and a change on a module (e.g., ec2_vpc_igw),
returning the 'target_to_test' containing ec2_vpc_igw and all modules
affected by the change in module_utils. At the moment, 'target_to_test'
is returned with only ec2_vpc_igw.

Co-Authored-by: Alina Buzachis [email protected]

@goneri goneri force-pushed the amazon-community-.aws-cross-project-testing_30696 branch from df9c7da to dfebe3f Compare February 15, 2022 19:49
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@goneri goneri force-pushed the amazon-community-.aws-cross-project-testing_30696 branch from dfebe3f to 209cbd1 Compare February 15, 2022 20:07
goneri added a commit to goneri/amazon.aws that referenced this pull request Feb 15, 2022
@goneri
DNM - CI TESTING
67ffbcf 
Depends-On: ansible/ansible-zuul-jobs#1357
@goneri goneri mentioned this pull request Feb 15, 2022
Closed
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@goneri goneri force-pushed the amazon-community-.aws-cross-project-testing_30696 branch 2 times, most recently from 35f2011 to 01ebc71 Compare February 15, 2022 20:23
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@goneri goneri force-pushed the amazon-community-.aws-cross-project-testing_30696 branch from 01ebc71 to 19ea592 Compare February 16, 2022 19:50
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@goneri goneri force-pushed the amazon-community-.aws-cross-project-testing_30696 branch from 19ea592 to 07c82a7 Compare February 16, 2022 20:05
@softwarefactory-project-zuul
Copy link
Contributor

Zuul encountered a syntax error while parsing its configuration in the
repo ansible/ansible-zuul-jobs on branch master. The error was:

while parsing a block collection
in "ansible/ansible-zuul-jobs/zuul.d/ansible-cloud-jobs.yaml@master", line 3, column 1
did not find expected '-' indicator
in "ansible/ansible-zuul-jobs/zuul.d/ansible-cloud-jobs.yaml@master", line 343, column 2

@goneri goneri force-pushed the amazon-community-.aws-cross-project-testing_30696 branch from 07c82a7 to 7bcb412 Compare February 16, 2022 20:12
@softwarefactory-project-zuul
Copy link
Contributor

Zuul encountered a syntax error while parsing its configuration in the
repo ansible/ansible-zuul-jobs on branch master. The error was:

Job ansible-test-cloud-integration-aws-py38_0 not defined

The error appears in the following project-template stanza:

project-template:
name: ansible-collections-amazon-aws
check:
queue: integrated-aws
jobs: &ansible-collections-amazon-aws-jobs
- ansible-test-sanity-aws-ansible-python38
- ansible-test-sanity-aws-ansible-2.9-python38
- ansible-test-sanity-aws-ansible-2.11-python38
- ansible-test-units-amazon-aws-python38
- build-ansible-collection:
required-projects:
- name: github.com/ansible-collections/ansible.utils
- name: github.com/ansible-collections/ansible.netcommon
- name: github.com/ansible-collections/community.aws
- name: github.com/ansible-collections/community.general
- name: github.com/ansible-collections/community.crypto
- ansible-test-splitter:
required-projects:
- name: github.com/ansible-collections/amazon.aws
- name: github.com/ansible-collections/community.aws
vars:
ansible_test_splitter__test_changed: true
ansible_test_splitter__check_for_changes_in:
- "/{{ zuul.projects['github.com/ansible-collections/amazon.aws'].src_dir }}"
- "/{{ zuul.projects['github.com/ansible-collections/community.aws'].src_dir }}"
- integration-amazon.aws-1
- integration-amazon.aws-2
- integration-amazon.aws-3
- integration-amazon.aws-4
- integration-amazon.aws-5
- integration-amazon.aws-6
- integration-amazon.aws-7
- integration-amazon.aws-8
- integration-amazon.aws-9
- integration-amazon.aws-10
- integration-community.aws-1
- integration-community.aws-2
- integration-community.aws-3
- integration-community.aws-4
- integration-community.aws-5
- integration-community.aws-6
- integration-community.aws-7
- integration-community.aws-8
- integration-community.aws-9
- integration-community.aws-10
gate:
queue: integrated-aws
jobs: *ansible-collections-amazon-aws-jobs
ondemand:
queue: integrated-aws
jobs:
- build-ansible-collection:
required-projects:
- name: github.com/ansible-collections/ansible.utils
- name: github.com/ansible-collections/ansible.netcommon
- name: github.com/ansible-collections/community.aws
- name: github.com/ansible-collections/community.general
- ansible-test-splitter:
vars:
ansible_test_splitter__test_changed: false
- ansible-test-cloud-integration-aws-py38_0
- ansible-test-cloud-integration-aws-py38_1
- ansible-test-cloud-integration-aws-py38_2
- ansible-test-cloud-integration-aws-py38_3
- ansible-test-cloud-integration-aws-py38_4
- ansible-test-cloud-integration-aws-py38_5

in "ansible/ansible-zuul-jobs/zuul.d/project-templates.yaml@master", line 54, column 3

@goneri goneri force-pushed the amazon-community-.aws-cross-project-testing_30696 branch from 7bcb412 to a7519bb Compare February 16, 2022 20:13
@softwarefactory-project-zuul
Copy link
Contributor

Zuul encountered a syntax error while parsing its configuration in the
repo ansible/ansible-zuul-jobs on branch master. The error was:

Job ansible-test-cloud-integration-aws-py38_0 not defined

The error appears in the following project-template stanza:

project-template:
name: ansible-collections-community-aws
check:
queue: integrated-aws
jobs: &ansible-collections-community-aws-jobs
- ansible-test-sanity-docker-devel
- ansible-test-sanity-docker-milestone
- ansible-test-sanity-docker-stable-2.9
- ansible-test-sanity-docker-stable-2.11
- ansible-test-sanity-docker-stable-2.12
- ansible-test-units-community-aws-python38
- build-ansible-collection:
required-projects:
- name: github.com/ansible-collections/amazon.aws
- name: github.com/ansible-collections/ansible.netcommon
- name: github.com/ansible-collections/ansible.utils
- name: github.com/ansible-collections/community.general
- name: github.com/ansible-collections/community.crypto
- ansible-test-splitter:
required-projects:
- name: github.com/ansible-collections/amazon.aws
- name: github.com/ansible-collections/community.aws
vars:
ansible_test_splitter__test_changed: true
ansible_test_splitter__check_for_changes_in:
- "/{{ zuul.projects['github.com/ansible-collections/amazon.aws'].src_dir }}"
- "/{{ zuul.projects['github.com/ansible-collections/community.aws'].src_dir }}"
- integration-community.aws-1
- integration-community.aws-2
- integration-community.aws-3
- integration-community.aws-4
- integration-community.aws-5
- integration-community.aws-6
- integration-community.aws-7
- integration-community.aws-8
- integration-community.aws-9
- integration-community.aws-10
- ansible-galaxy-importer:
voting: false
third-party-check:
jobs:
- ansible-galaxy-importer:
voting: false
gate:
queue: integrated-aws
jobs: *ansible-collections-community-aws-jobs
ondemand:
queue: integrated-aws
jobs:
- build-ansible-collection:
required-projects:
- name: github.com/ansible-collections/amazon.aws
- name: github.com/ansible-collections/ansible.netcommon
- name: github.com/ansible-collections/ansible.utils
- name: github.com/ansible-collections/community.general
- ansible-test-splitter:
vars:
ansible_test_splitter__test_changed: false
- ansible-test-cloud-integration-aws-py38_0
- ansible-test-cloud-integration-aws-py38_1
- ansible-test-cloud-integration-aws-py38_2
- ansible-test-cloud-integration-aws-py38_3
- ansible-test-cloud-integration-aws-py38_4
- ansible-test-cloud-integration-aws-py38_5
- ansible-galaxy-importer:
voting: false

in "ansible/ansible-zuul-jobs/zuul.d/project-templates.yaml@master", line 135, column 3

@goneri goneri force-pushed the amazon-community-.aws-cross-project-testing_30696 branch 2 times, most recently from 0767b6f to bd7272a Compare February 16, 2022 20:32
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@goneri goneri force-pushed the amazon-community-.aws-cross-project-testing_30696 branch from bd7272a to 9a9e85e Compare February 16, 2022 21:52
@goneri
Copy link
Collaborator Author

goneri commented Feb 16, 2022

@alinabuzachis, the PR is ready for review.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@goneri
Copy link
Collaborator Author

goneri commented Feb 17, 2022

Actually, there is a problem https://ansible.softwarefactory-project.io/zuul/build/04c19185926b45958626059af94324cd

@alinabuzachis alinabuzachis mentioned this pull request Feb 17, 2022
Closed
@goneri goneri force-pushed the amazon-community-.aws-cross-project-testing_30696 branch from 9a9e85e to 53b5842 Compare February 17, 2022 15:28
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@goneri goneri force-pushed the amazon-community-.aws-cross-project-testing_30696 branch from 53b5842 to 75616a5 Compare February 17, 2022 15:57
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@goneri goneri force-pushed the amazon-community-.aws-cross-project-testing_30696 branch from 75616a5 to 0ce9500 Compare February 17, 2022 16:17
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

alinabuzachis
alinabuzachis approved these changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goneri Thank you Goneri. Awesome!

@goneri goneri mentioned this pull request Feb 17, 2022
Closed
@goneri goneri force-pushed the amazon-community-.aws-cross-project-testing_30696 branch from 0ce9500 to a3b3e39 Compare February 17, 2022 18:59
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@alinabuzachis alinabuzachis mentioned this pull request Feb 17, 2022
Merged
@goneri goneri force-pushed the amazon-community-.aws-cross-project-testing_30696 branch from a3b3e39 to a4091ce Compare February 21, 2022 16:36
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@goneri goneri force-pushed the amazon-community-.aws-cross-project-testing_30696 branch 2 times, most recently from c14f919 to 0a56e39 Compare February 21, 2022 17:27
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@goneri goneri force-pushed the amazon-community-.aws-cross-project-testing_30696 branch from 0a56e39 to 6ec04a3 Compare February 21, 2022 17:59
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@goneri goneri force-pushed the amazon-community-.aws-cross-project-testing_30696 branch from 6ec04a3 to a091ac9 Compare February 21, 2022 19:47
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@goneri goneri added the mergeit Merge the PR (SoftwareFActory) label Feb 21, 2022
@goneri goneri closed this Feb 21, 2022
@goneri goneri reopened this Feb 21, 2022
@goneri goneri removed the mergeit Merge the PR (SoftwareFActory) label Feb 21, 2022
@alinabuzachis @goneri
{amazon,community}.aws: cross-project testing
6613f32 
If there is a change in module_utils, run the CI only for the modules
affected by that change.
This also solves the case where in the same PR there is a change in a
module_utils file (e.g., rds) and a change on a module (e.g., ec2_vpc_igw),
returning the 'target_to_test' containing ec2_vpc_igw and all modules
affected by the change in module_utils. At the moment, 'target_to_test'
is returned with only ec2_vpc_igw.

Co-Authored-by: Alina Buzachis <[email protected]>
@goneri goneri force-pushed the amazon-community-.aws-cross-project-testing_30696 branch from a091ac9 to 6613f32 Compare February 21, 2022 20:23
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@goneri goneri added the mergeit Merge the PR (SoftwareFActory) label Feb 21, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 830aa42 into ansible:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFActory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goneri @alinabuzachis