added wait to fix delete version test #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fullsushidev
previously requested changes
Aug 26, 2024
nixocio
reviewed
Aug 26, 2024
fullsushidev
force-pushed
the
fix_delete_version
branch
from
6584ba6
to
04d7a46
Compare
forcing cypress to wait for the element to be visible thus preventing flakiness. Co-authored-by: Or Hochmann <[email protected]>
to be fixed in the next PR
|
fullsushidev
requested review from
fullsushidev and
MilanPospisil
and removed request for
fullsushidev
MilanPospisil
dismissed
fullsushidev’s stale review
We need to merge it ASAP. We can discuss it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to AAP-29895