Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UXD][AAP-28389] AWX - updates to Jobs and Templates section popovers #2931

Merged
merged 1 commit into from
Aug 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions frontend/awx/resources/templates/JobTemplateInputs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -151,15 +151,15 @@ export function JobTemplateInputs(props: { jobtemplate?: JobTemplateForm }) {
placeholder={t('Select credentials')}
labelHelpTitle={t('Credentials')}
labelHelp={t(
'Select credentials for accessing the nodes this job will be ran against. You can only select one credential of each type. For machine credentials (SSH), checking "Prompt on launch" without selecting credentials will require you to select a machine credential at run time. If you select credentials and check "Prompt on launch", the selected credential(s) become the defaults that can be updated at run time.'
'Select credentials for accessing the nodes this job will be ran against. You can only select one credential of each type. For machine credentials (SSH), checking "Prompt on launch" without selecting credentials will require you to select a machine credential at run time. If you select credentials and check "Prompt on launch," the selected credential(s) become the defaults that can be updated at run time.'
)}
isMultiple
queryParams={{ credential_type__kind__in: acceptableCredentialKinds.join(',') }}
/>
<PageFormLabelSelect
labelHelpTitle={t('Labels')}
labelHelp={t(
`Optional labels that describe this job template, such as 'dev' or 'test'. Labels can be used to group and filter job templates and completed jobs.`
`Optional labels that describe this job template, such as 'dev' or 'test.' Labels can be used to group and filter job templates and completed jobs.`
)}
name="labels"
additionalControls={
Expand Down Expand Up @@ -199,7 +199,7 @@ export function JobTemplateInputs(props: { jobtemplate?: JobTemplateForm }) {
name="verbosity"
type="number"
labelHelpTitle={t('Verbosity')}
labelHelp={t('Control the level of output ansible will produce as the playbook executes.')}
labelHelp={t('Control the level of output Ansible will produce as the playbook executes.')}
label={t('Verbosity')}
/>
<PageFormTextInput<JobTemplateForm>
Expand Down Expand Up @@ -279,7 +279,7 @@ export function JobTemplateInputs(props: { jobtemplate?: JobTemplateForm }) {
<PageFormCheckbox label={t('Prompt on launch')} name="ask_variables_on_launch" />
}
labelHelpTitle={t('Extra Variables')}
labelHelp={t(`Optional extra variables to be applied to job template`)}
labelHelp={t(`Optional extra variables to be applied to job template.`)}
format="yaml"
label={t('Extra Variables')}
name="extra_vars"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export function WorkflowJobTemplateInputs(props: {
<PageFormCheckbox label={t('Prompt on launch')} name="ask_variables_on_launch" />
}
labelHelpTitle={t('Extra Variables')}
labelHelp={t(`Optional extra variables to be applied to job template`)}
labelHelp={t(`Optional extra variables to be applied to job template.`)}
format="yaml"
label={t('Extra Variables')}
name="extra_vars"
Expand Down
2 changes: 1 addition & 1 deletion frontend/awx/views/jobs/JobDetails.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export function JobDetails() {
</PageDetail>
<PageDetail
label={t('Verbosity')}
helpText={t('Control the level of output ansible will produce as the playbook executes.')}
helpText={t('Control the level of output Ansible will produce as the playbook executes.')}
>
{verbosity}
</PageDetail>
Expand Down
2 changes: 1 addition & 1 deletion frontend/awx/views/jobs/hooks/useJobsColumns.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ export function useJobsColumns(options?: { disableSort?: boolean; disableLinks?:
{job.summary_fields?.inventory?.name}
</Link>
),
helpText: t('Inventory used on this job'),
helpText: t('Inventory used on this job.'),
value: (job: UnifiedJob) => job.summary_fields?.inventory?.name,
table: ColumnTableOption.expanded,
card: 'hidden',
Expand Down
Loading