Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate pylint-pytest plugin #782

Merged

Conversation

webknjaz
Copy link
Member

This patch is necessary because pylint does not autoactivate third-
party plugins just because they are installed in the same virtualenv.

It seems like this bit of the original configuration got lost over
time: the Python distribution package is present in the dependencies
and gets installed but pylint does not use it. With this change, it
becomes used again.

@webknjaz webknjaz added tests Related to testing and CI bot:chronographer:skip labels Jan 21, 2022
@webknjaz
Copy link
Member Author

(not expecting reviews because it's a correction of a misconfiguration that was expected to work earlier)

@cidrblock cidrblock removed the gate label Jan 23, 2022
@cidrblock
Copy link
Collaborator

I'd like an opportunity to review this, even if it is a correction
Can you please request reviews? I know it's might seem silly, but it is still a change to the code base.

@webknjaz
Copy link
Member Author

@cidrblock sure, feel free to re-gate as well. Looks like Zuul was drunk.

@webknjaz webknjaz added the gate label Jan 25, 2022
This patch is necessary because `pylint` does not autoactivate third-
party plugins just because they are installed in the same virtualenv.

It seems like this bit of the original configuration got lost over
time: the Python distribution package is present in the dependencies
and gets installed but `pylint` does not use it. With this change, it
becomes used again.
@webknjaz webknjaz force-pushed the maintenance/activate-pylint-pytest branch from a8d315e to f00bb73 Compare January 26, 2022 12:17
@ansible-zuul ansible-zuul bot removed the gate label Jan 26, 2022
@webknjaz webknjaz added the gate label Jan 26, 2022
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cidrblock cidrblock added gate and removed gate labels Jan 26, 2022
@ansible-zuul ansible-zuul bot merged commit 0a6ec02 into ansible:main Jan 26, 2022
@ssbarnea ssbarnea mentioned this pull request Feb 2, 2022
ssbarnea pushed a commit to ssbarnea/ansible-navigator that referenced this pull request Feb 12, 2022
Activate `pylint-pytest` plugin

This patch is necessary because pylint does not autoactivate third-
party plugins just because they are installed in the same virtualenv.
It seems like this bit of the original configuration got lost over
time: the Python distribution package is present in the dependencies
and gets installed but pylint does not use it. With this change, it
becomes used again.

Reviewed-by: Bradley A. Thornton <[email protected]>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Related to testing and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants