Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extra parameters when playbook is defined in configuration/settings file #1474

Merged
merged 9 commits into from
Apr 24, 2023

Conversation

shatakshiiii
Copy link
Contributor

@shatakshiiii shatakshiiii commented Apr 3, 2023

Summary:

With this, all the parameters that are not directly supported by ansible-navigator and usually used via a -- delimiter, can also be used when playbook is defined in the navigator's settings file.

This will allow ansible-navigator run to support extra parameters when playbook is specified in the configuration (instead of command itself)

Example: ansible-navigator run -- -e my_var=value

When configuration can be something like :

---
ansible-navigator:
  ansible:
    playbook:
      path: "playbooks/ping.yml"

Fixes: #1437

@github-actions github-actions bot added the bug Researched, reproducible, committed to fix label Apr 3, 2023
@shatakshiiii shatakshiiii marked this pull request as ready for review April 5, 2023 11:18
Copy link
Collaborator

@cidrblock cidrblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@shatakshiiii shatakshiiii merged commit aaa70ed into ansible:main Apr 24, 2023
@shatakshiiii shatakshiiii deleted the fix_arg_parse branch April 24, 2023 16:04
@shatakshiiii shatakshiiii self-assigned this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Researched, reproducible, committed to fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't run playbook from configuration with extra-vars in parameters
2 participants