Handle bare exception case from nested jinja2 vars #4315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cavcrosby
requested review from
ssbarnea and
shatakshiiii
and removed request for
a team
|
ssbarnea
force-pushed
the
handle-exception-nested-vars
branch
from
4371938 to
8f4ca17
Compare
ssbarnea
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4298
I sometimes found that nested
jinja2variables cause the base exception to be thrown from an instance ofAnsibleJ2Vars(which is used within theTemplar.do_templatemethod). This can happen I believe from the call toreturn self._templar.template(variable)withinAnsibleJ2Vars. Through testing, I found that Python version3.10doesn't reproduce this issue, but3.11and3.12do.