Fix UX nitpicks on Collections page

[newswangerd]

[romanblanco]

@newswangerd to be consistent with b68a370, could we adjust the empty state for search on Partners and Namespaces page as well?

The changes in b68a370 look good!

[romanblanco]

Maybe to consider: at the empty state, we could give the user a hint on what would be the next action (see ManageIQ/manageiq-ui-classic#5434 (comment)).

@sbuenafe-rh could know, if that is something we want to do.

[sbuenafe-rh]

@newswangerd Collections pages look good. I would want to make sure that there's 24px between the card/list view buttons and the compact pagination component.

Also, for the filter input field, are we filtering by the name of the collection? If so, I would change the placeholder text to be "Filter by collection".

[sbuenafe-rh]

@romanblanco the Partners page, no results found/matched, the message should be the same as the no collections found. See mock for reference: https://marvelapp.com/project/4271938/screen/65612952

[sbuenafe-rh]

@romanblanco also, for the My namespaces empty page (Day 1 user), the toolbar should be removed and the action button to create a namespace should be in the empty state message. See mock for reference: https://marvelapp.com/project/4271938/screen/65785967

[sbuenafe-rh]

For a PF Empty state component reference, the pages that we've talked about to should be using the Empty State - Large. See PF documentation: https://www.patternfly.org/v4/documentation/core/components/emptystate#large

[newswangerd]

@sbuenafe-rh

Also, for the filter input field, are we filtering by the name of the collection? If so, I would change the placeholder text to be "Filter by collection".

I checked. It performs a search, not a filter.

[sbuenafe-rh]

@newswangerd

Also, for the filter input field, are we filtering by the name of the collection? If so, I would change the placeholder text to be "Filter by collection".

I checked. It performs a search, not a filter.

Ok knowing this, the no matches found message will probably need to be tweaked.