Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-4.10] Bump node to v20 (#5107) #5236

Merged
merged 3 commits into from
Dec 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/automerge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
- name: "Checkout ansible-hub-ui (${{ github.ref }})"
uses: actions/checkout@v4

- name: "Install node 18"
- name: "Install node 20"
uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'

- name: "Check automerge conditions"
working-directory: ".github/workflows"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/cypress.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,10 @@ jobs:
working-directory: 'oci_env'
run: 'oci-env compose up &'

- name: "Install node 18"
- name: "Install node 20"
uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'

- name: "Cache ~/.npm & ~/.cache/Cypress"
uses: actions/cache@v4
Expand Down
13 changes: 9 additions & 4 deletions .github/workflows/pr-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,17 @@ jobs:
- name: "Checkout ansible-hub-ui (${{ github.ref }})"
uses: actions/checkout@v4

- name: "Install node 18"
- name: "Install node 20"
uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'
cache: 'npm'

- name: "Install python 3.11"
uses: actions/setup-python@v5
with:
python-version: '3.11'

- name: "Checks"
run: |
# fail if npm install had to change package-lock.json
Expand Down Expand Up @@ -88,10 +93,10 @@ jobs:
with:
path: 'pr'

- name: "Install node 18"
- name: "Install node 20"
uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'
cache: 'npm'
cache-dependency-path: |
base/package-lock.json
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/stable-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ jobs:
RELEASE_TAG=`sed 's/^refs\/tags\///' <<< $GITHUB_REF`
echo "RELEASE_TAG=${RELEASE_TAG}" >> $GITHUB_ENV

- name: "Install node 18"
- name: "Install node 20"
uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'

- name: "Cache ~/.npm"
uses: actions/cache@v4
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# WARNING
# This Dockerfile is intended for development purposes only. Do not use it for production deployments

FROM node:18-alpine
FROM node:20-alpine
WORKDIR /hub/

RUN mkdir -p /hub/app/ && \
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
"start-standalone": "NODE_ENV=development webpack serve --host 0.0.0.0 --config config/standalone.dev.webpack.config.js"
},
"engines": {
"node": ">=18",
"npm": ">=9"
"node": ">=20",
"npm": ">=10"
}
}
22 changes: 0 additions & 22 deletions test/cypress/e2e/community/feature-flags.js

This file was deleted.

Loading