Repository edit: respect object permissions #3628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously the permission check for rendering the edit form would happen before loading the repository, so we only used the global permissions .. postponing check until item has been loaded Issue: AAH-2305
github-actions
bot
added
backport-4.6
This comment was marked as outdated.
This comment was marked as outdated.
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Apr 24, 2023
previously the permission check for rendering the edit form would happen before loading the repository, so we only used the global permissions .. postponing check until item has been loaded Issue: AAH-2305 (cherry picked from commit 9610edb)
github-actions
bot
added
the
backported-4.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: AAH-2305
Repository edit - when logged in as unprivileged user, with no global repository permissions, but yes object permissions to a specific repository,
you can see the repository edit button (since #3602),
but clicking it leads to the unauthorized page ... fixing.
Previously the permission check for rendering the edit form would happen before loading the repository, so we only used the global permissions .. postponing check until item has been loaded.