Use display_repositories feature flag
#3558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-4.6
himdel
force-pushed
the
display_repositories
branch
from
cc1eaaf
to
0aaa0d0
Compare
himdel
added
backport-4.7
himdel
force-pushed
the
display_repositories
branch
from
0aaa0d0
to
5b00a2f
Compare
without it: hide repo link in collections view, hide repo selector, hide menu item with it: show menu item in anonymous mode too No-Issue
himdel
force-pushed
the
display_repositories
branch
from
5b00a2f
to
d441815
Compare
|
Backporting for code consistency.. but the actual feature flag is NOT available in 4.7, hardcoding to true there. |
This comment was marked as outdated.
This comment was marked as outdated.
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Apr 24, 2023
* FeatureFlagsType: add ai_deny_index, display_repositories * Use display_repositories feature flag without it: hide repo link in collections view, hide repo selector, hide menu item with it: show menu item in anonymous mode too No-Issue * view-only tests - run with more community feature flags (cherry picked from commit 67e6e97)
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Apr 24, 2023
* FeatureFlagsType: add ai_deny_index, display_repositories * Use display_repositories feature flag without it: hide repo link in collections view, hide repo selector, hide menu item with it: show menu item in anonymous mode too No-Issue * view-only tests - run with more community feature flags (cherry picked from commit 67e6e97)
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Apr 24, 2023
* FeatureFlagsType: add ai_deny_index, display_repositories * Use display_repositories feature flag without it: hide repo link in collections view, hide repo selector, hide menu item with it: show menu item in anonymous mode too No-Issue * view-only tests - run with more community feature flags (cherry picked from commit 67e6e97)
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
May 22, 2023
* FeatureFlagsType: add ai_deny_index, display_repositories * Use display_repositories feature flag without it: hide repo link in collections view, hide repo selector, hide menu item with it: show menu item in anonymous mode too No-Issue * view-only tests - run with more community feature flags (cherry picked from commit 67e6e97)
himdel
added a commit
that referenced
this pull request
May 30, 2023
* Use `display_repositories` feature flag (#3558) * FeatureFlagsType: add ai_deny_index, display_repositories * Use display_repositories feature flag without it: hide repo link in collections view, hide repo selector, hide menu item with it: show menu item in anonymous mode too No-Issue * view-only tests - run with more community feature flags (cherry picked from commit 67e6e97) * without the feature flag * fix tests
github-actions
bot
added
the
backported-4.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ansible/galaxy_ng#1669
Issue AAH-2269
There's a new
display_repositoriesfeature flag,without it:
hide repo link in collections view,
hide repo selector,
hide menu item
with it:
show menu item in anonymous mode too