use name instead of source for installing collection dir requirements #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-hertel
changed the title
s-hertel
changed the title
samccann
approved these changes
Dec 10, 2024
samccann
added
backport-2.16
oraNod
approved these changes
Dec 11, 2024
Backport to stable-2.16: 💚 backport PR created✅ Backport PR branch: Backported as #2285 🤖 @patchback |
Backport to stable-2.17: 💚 backport PR created✅ Backport PR branch: Backported as #2286 🤖 @patchback |
Backport to stable-2.18: 💚 backport PR created✅ Backport PR branch: Backported as #2287 🤖 @patchback |
oraNod
pushed a commit
that referenced
this pull request
Dec 11, 2024
…ories (#2259) (#2287) (cherry picked from commit 2e09b53) Co-authored-by: Sloane Hertel <[email protected]>
oraNod
pushed a commit
that referenced
this pull request
Dec 11, 2024
…ories (#2259) (#2286) (cherry picked from commit 2e09b53) Co-authored-by: Sloane Hertel <[email protected]>
oraNod
pushed a commit
that referenced
this pull request
Dec 11, 2024
…ories (#2259) (#2285) (cherry picked from commit 2e09b53) Co-authored-by: Sloane Hertel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should have caught this before approving the PR that added these examples.
When the dependency resolver was added to ansible-galaxy in 2.12, it inadvertently overloaded the
sourcecollection requirement field, which was previously only able to be a URL to a galaxy server. Now it is sort of an alias tonamein some situations, and it's a bug because we had specifically discussed not unifying rolesrcvs collectionsourcefor requirements, because although it's unfortunate that they're similarly named but completely different features (one is a URL to a role, the other is a URL galaxy server), it was outside of the scope of that PR (and at the time of discussion, I was under the impression we would want to make the role syntax more like collections though - not the other way around).