Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to templating functions from the variables page #2258

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Link to templating functions from the variables page #2258

merged 2 commits into from
Dec 10, 2024

Conversation

s-hertel
Copy link
Contributor

@s-hertel s-hertel commented Dec 5, 2024

Related to ansible/ansible#84427. All of the templating global functions can be overwritten with a variable.

I also noticed query/q wasn't documented with the other global templating functions so I added it.

@s-hertel
Link to templating functions from the variables page
88f9eac 
Add query/q templating function to the working with playbooks page
@s-hertel s-hertel marked this pull request as ready for review December 5, 2024 17:01
@samccann
Copy link
Contributor

@s-hertel - how far back is this applicable? The linked issue says '2.17' but I can't tell if that's accurate or if we should backport this down to 2.16?

@s-hertel
Copy link
Contributor Author

@samccann Thanks for the review. Backporting to 2.16 would be good if possible, this limitation affects all versions. The undef function was added most recently (in ansible-core 2.12 ansible/ansible@989eeb2), so this can be backporting as far back as 2.12 without modification.

@samccann samccann added backport-2.16 Automatically create a backport for the stable-2.16 branch backport-2.17 Automatically create a backport for the stable-2.17 branch backport-2.18 Automatically create a backport for the stable-2.18 branch labels Dec 10, 2024
@samccann samccann merged commit 2b7145d into ansible:devel Dec 10, 2024
11 checks passed
@patchback Patchback
Copy link

patchback bot commented Dec 10, 2024 •
edited
Loading

Backport to stable-2.16: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.16/2b7145d199189be6679186cbd35dd570c41bd160/pr-2258

Backported as #2281

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 10, 2024
@s-hertel @patchback
Link to templating functions from the variables page (#2258)
17146f4 
* Link to templating functions from the variables page

Add query/q templating function to the working with playbooks page

* fix typos, simplify example

(cherry picked from commit 2b7145d)
@patchback patchback bot mentioned this pull request Dec 10, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented Dec 10, 2024 •
edited
Loading

Backport to stable-2.17: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.17/2b7145d199189be6679186cbd35dd570c41bd160/pr-2258

Backported as #2282

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@samccann
Copy link
Contributor

Cool thanks. Backports come free and easy now thanks to a bot. Just added labels on the side for each release and let it do its magic!

patchback bot pushed a commit that referenced this pull request Dec 10, 2024
@s-hertel @patchback
Link to templating functions from the variables page (#2258)
d4fa03a 
* Link to templating functions from the variables page

Add query/q templating function to the working with playbooks page

* fix typos, simplify example

(cherry picked from commit 2b7145d)
@patchback patchback bot mentioned this pull request Dec 10, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented Dec 10, 2024 •
edited
Loading

Backport to stable-2.18: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.18/2b7145d199189be6679186cbd35dd570c41bd160/pr-2258

Backported as #2283

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 10, 2024
@s-hertel @patchback
Link to templating functions from the variables page (#2258)
7185731 
* Link to templating functions from the variables page

Add query/q templating function to the working with playbooks page

* fix typos, simplify example

(cherry picked from commit 2b7145d)
@patchback patchback bot mentioned this pull request Dec 10, 2024
Merged
oraNod pushed a commit that referenced this pull request Dec 11, 2024
@patchback @s-hertel
Link to templating functions from the variables page (#2258) (#2283)
f3fe0e5 
* Link to templating functions from the variables page

Add query/q templating function to the working with playbooks page

* fix typos, simplify example

(cherry picked from commit 2b7145d)

Co-authored-by: Sloane Hertel <[email protected]>
oraNod pushed a commit that referenced this pull request Dec 11, 2024
@patchback @s-hertel
Link to templating functions from the variables page (#2258) (#2282)
5760793 
* Link to templating functions from the variables page

Add query/q templating function to the working with playbooks page

* fix typos, simplify example

(cherry picked from commit 2b7145d)

Co-authored-by: Sloane Hertel <[email protected]>
oraNod pushed a commit that referenced this pull request Dec 11, 2024
@patchback @s-hertel
Link to templating functions from the variables page (#2258) (#2281)
aea6d76 
* Link to templating functions from the variables page

Add query/q templating function to the working with playbooks page

* fix typos, simplify example

(cherry picked from commit 2b7145d)

Co-authored-by: Sloane Hertel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samccann samccann samccann approved these changes

Assignees
No one assigned
Labels
backport-2.16 Automatically create a backport for the stable-2.16 branch backport-2.17 Automatically create a backport for the stable-2.17 branch backport-2.18 Automatically create a backport for the stable-2.18 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-hertel @samccann