Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #1633 nox session for tagging #1649
Issue #1633 nox session for tagging #1649
Changes from 4 commits
2472bdc
bf5a851
4710cb6
79f8142
d57278c
bc411d7
50d0694
7694050
fcee50f
e7e2884
8a81a59
9651682
90a1ea7
8ee0016
38585f9
9ca0b2b
81db0a1
418f5da
7579072
6d5af07
5536dad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about cloning the core repo as part of this session. The tagger script already determines the default core checkout and an extra clone feels wasteful.
This also requires you to set the
--core
argument when running the tagger if you want to use the existing core checkout, which seems a bit less convenient than using the tagger directly.Maybe we could call
tag.py
to catch when theansible
repo doesn't exist and then do the clone?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. Now I'm on the fence. I guess the clone here resolves the need to set the
--remote
arg if it's notorigin
as well as making sure that the repo is up to date.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I had a lot of the same thoughts.
What I landed on for a first pass was designing around the idea of
"running
nox -s tag
should require little/no knowledge of how the tagging tool works under the hood, and should 'just work'"Based on running the tag tool multiple times, I'm fairly confident I know (relative to the docs directory) where it expects core to be. I can add in a test for if it already exists either there or in the tmp location, and potentially some other checks to confirm branches etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@x1101 that makes sense and maybe I'm coming around to the idea of doing the clone here. One thing I think it's important to avoid is making the nox session too complex and my suggestions could be pushing things down the wrong path. The nox session should only be a light wrapper to the tagger script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be integrated into the automatic dependency update job.