Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump antsibull-docs to 2.11.0 #1417

Merged
merged 1 commit into from
May 6, 2024

Conversation

felixfontein
Copy link
Collaborator

Should fix ansible/ansible#83204.

@felixfontein felixfontein added backport-2.15 Automatically create a backport for the stable-2.15 branch backport-2.16 Automatically create a backport for the stable-2.16 branch backport-2.17 Automatically create a backport for the stable-2.17 branch labels May 6, 2024
@felixfontein
Copy link
Collaborator Author

@felixfontein felixfontein merged commit 43d8a1f into ansible:devel May 6, 2024
7 of 8 checks passed
Copy link

patchback bot commented May 6, 2024

Backport to stable-2.15: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 43d8a1f on top of patchback/backports/stable-2.15/43d8a1fcde94240a5884ec509443a6bff9721f4d/pr-1417

Backporting merged PR #1417 into devel

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible/ansible-documentation.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-2.15/43d8a1fcde94240a5884ec509443a6bff9721f4d/pr-1417 upstream/stable-2.15
  4. Now, cherry-pick PR Bump antsibull-docs to 2.11.0 #1417 contents into that branch:
    $ git cherry-pick -x 43d8a1fcde94240a5884ec509443a6bff9721f4d
    If it'll yell at you with something like fatal: Commit 43d8a1fcde94240a5884ec509443a6bff9721f4d is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 43d8a1fcde94240a5884ec509443a6bff9721f4d
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Bump antsibull-docs to 2.11.0 #1417 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-2.15/43d8a1fcde94240a5884ec509443a6bff9721f4d/pr-1417
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the antsibull-docs branch May 6, 2024 20:50
Copy link

patchback bot commented May 6, 2024

Backport to stable-2.16: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 43d8a1f on top of patchback/backports/stable-2.16/43d8a1fcde94240a5884ec509443a6bff9721f4d/pr-1417

Backporting merged PR #1417 into devel

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible/ansible-documentation.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-2.16/43d8a1fcde94240a5884ec509443a6bff9721f4d/pr-1417 upstream/stable-2.16
  4. Now, cherry-pick PR Bump antsibull-docs to 2.11.0 #1417 contents into that branch:
    $ git cherry-pick -x 43d8a1fcde94240a5884ec509443a6bff9721f4d
    If it'll yell at you with something like fatal: Commit 43d8a1fcde94240a5884ec509443a6bff9721f4d is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 43d8a1fcde94240a5884ec509443a6bff9721f4d
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Bump antsibull-docs to 2.11.0 #1417 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-2.16/43d8a1fcde94240a5884ec509443a6bff9721f4d/pr-1417
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link

patchback bot commented May 6, 2024

Backport to stable-2.17: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.17/43d8a1fcde94240a5884ec509443a6bff9721f4d/pr-1417

Backported as #1418

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 6, 2024
felixfontein added a commit to felixfontein/ansible-documentation that referenced this pull request May 6, 2024
samccann pushed a commit that referenced this pull request May 7, 2024
samccann pushed a commit that referenced this pull request May 7, 2024
(cherry picked from commit 43d8a1f)

Co-authored-by: Felix Fontein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2.15 Automatically create a backport for the stable-2.15 branch backport-2.16 Automatically create a backport for the stable-2.16 branch backport-2.17 Automatically create a backport for the stable-2.17 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression error - package_facts module changes fails ansible-documentation CI
2 participants