-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate ansible-creator and devtools into the developing collections guide #1302
Conversation
Thanks for your Ansible docs contribution! We talk about Ansible documentation on matrix at #docs:ansible.im and on libera IRC at #ansible-docs if you ever want to join us and chat about the docs! We meet there on Tuesdays (see the Ansible calendar) and welcome additions to our weekly agenda items - scroll down to find the upcoming agenda and add a comment to put something new on that agenda. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the docs update @xszabo3 I've made a few suggestions for you. Feel free to rewrite and work with them however you see fit.
Also @xszabo3 I just realized you opened this PR as a draft. If you're not ready for review comments yet, please just ignore what I put in there. |
Thanks for the feedback @oraNod . I will make the changes when I have time in the following days, I also asked a few questions in the matrix channel after making this draft. |
@oraNod I haven't received an answer on matrix, so I will repeat the questions here: 1: 2: |
hey @xszabo3 I might have missed those questions in matrix. as a general rule of thumb it's better to ask questions related to a PR or issue directly in the thread. it's especially helpful to have the full context in one place for historical purposes too.
|
@Andersson007 Hi, I think we should get your perspective on this because we don't want to deviate too much from the collection template repository in community. Could you please take a look and share any opinion on using the |
Thanks for the response @oraNod , I just opened a PR for the typo. |
After changing the anchors, I think the first point deserves a rewrite, to include ansible-creator I have a few suggestions:
2:
3:
4: Leave it as it is Which one would be the most ideal, or do you have other ideas @oraNod @samccann ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution @xszabo3
Backport to stable-2.15: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply fd3495a on top of patchback/backports/stable-2.15/fd3495af6394922cfc81344c42133a0fb62f98c7/pr-1302 Backporting merged PR #1302 into devel
🤖 @patchback |
Thanks @xszabo3 for the Ansible docs fix! |
Backport to stable-2.14: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply fd3495a on top of patchback/backports/stable-2.14/fd3495af6394922cfc81344c42133a0fb62f98c7/pr-1302 Backporting merged PR #1302 into devel
🤖 @patchback |
Backport to stable-2.16: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply fd3495a on top of patchback/backports/stable-2.16/fd3495af6394922cfc81344c42133a0fb62f98c7/pr-1302 Backporting merged PR #1302 into devel
🤖 @patchback |
Backport to stable-2.17: 💚 backport PR created✅ Backport PR branch: Backported as #1399 🤖 @patchback |
…s guide (#1302) * doc: integrate ansible-creator in developing_collections_creating.rst * doc: corrections based on feedback * doc: highlight ansible-creator in note * doc: corrections based on review * doc: move ansible-creator section, rename anchor * doc: rewrite ADT note based on suggestion * doc: change links from github to readthedocs (cherry picked from commit fd3495a)
Thank you all for your patience. |
…s guide (#1302) (#1402) * doc: integrate ansible-creator in developing_collections_creating.rst * doc: corrections based on feedback * doc: highlight ansible-creator in note * doc: corrections based on review * doc: move ansible-creator section, rename anchor * doc: rewrite ADT note based on suggestion * doc: change links from github to readthedocs (cherry picked from commit fd3495a)
…s guide (#1302) (#1403) * doc: integrate ansible-creator in developing_collections_creating.rst * doc: corrections based on feedback * doc: highlight ansible-creator in note * doc: corrections based on review * doc: move ansible-creator section, rename anchor * doc: rewrite ADT note based on suggestion * doc: change links from github to readthedocs (cherry picked from commit fd3495a)
…s guide (#1302) (#1401) * doc: integrate ansible-creator in developing_collections_creating.rst * doc: corrections based on feedback * doc: highlight ansible-creator in note * doc: corrections based on review * doc: move ansible-creator section, rename anchor * doc: rewrite ADT note based on suggestion * doc: change links from github to readthedocs (cherry picked from commit fd3495a)
…s guide (#1302) (#1399) * doc: integrate ansible-creator in developing_collections_creating.rst * doc: corrections based on feedback * doc: highlight ansible-creator in note * doc: corrections based on review * doc: move ansible-creator section, rename anchor * doc: rewrite ADT note based on suggestion * doc: change links from github to readthedocs (cherry picked from commit fd3495a) Co-authored-by: xszabo3 <[email protected]>
This branch adds a section mentioning ansible-creator as a way to generate collection structure. Mentioned in #1294