Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove triage label from PRs #628

Closed
samccann opened this issue Oct 17, 2023 · 3 comments · Fixed by #643
Closed

Remove triage label from PRs #628

samccann opened this issue Oct 17, 2023 · 3 comments · Fixed by #643
Assignees
@gotmax23
Labels
pr_labeler Issue or PR in the pr_labeler triager bot tooling This PR affects tooling (CI, pr_labeler, noxfile, linters, etc.) but not the docs builds themselves.

Comments

@samccann
Copy link
Contributor

Our PR queue is quite small and multiple people are merging so it seems none of us really need the triage label on PRs.

The proposal is to remove them from PRs altogether.
@github-actions github-actions bot added the needs_triage Needs a first human triage before being processed. label Oct 17, 2023
@samccann
Copy link
Contributor Author

@oraNod @felixfontein - do you see any value in having this label on PRs? As I mentioned in the meeting today - we're merging w/o removing it and with less than a github page of PRs listed, doesn't seem like we're losing track of moving PRs along so ..feels like extra label noise at this point.

for the record, I'm the one that requested this label so...mea culpa :-)

@gotmax23
Copy link
Collaborator

For the record, all this entails is removing this line

ansible-documentation/hacking/pr_labeler/label.py

Line 271 in 96d5929

add_label_if_new(ctx, "needs_triage")

@gotmax23 gotmax23 added tooling This PR affects tooling (CI, pr_labeler, noxfile, linters, etc.) but not the docs builds themselves. pr_labeler Issue or PR in the pr_labeler triager bot and removed needs_triage Needs a first human triage before being processed. labels Oct 17, 2023
@oraNod
Copy link
Contributor

oraNod commented Oct 17, 2023

Yeah I'm in favour of dropping this label. I think needs_triage should be a manual thing in cases where there are questions or we need to discuss a particular course of action or whatever.

gotmax23 added a commit to gotmax23/ansible-documentation that referenced this issue Oct 17, 2023
@gotmax23
pr_labeler: stop adding new_triage labels to new PRs
005980f 
Fixes: ansible#628
@gotmax23 gotmax23 mentioned this issue Oct 17, 2023
Merged
@gotmax23 gotmax23 moved this from 🆕 Triage to 👀 In review in Ansible Documentation Oct 17, 2023
gotmax23 added a commit that referenced this issue Oct 18, 2023
@gotmax23
pr_labeler: stop adding new_triage labels to new PRs (#643)
e43d253 
Fixes: #628
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Ansible Documentation Oct 18, 2023
patchback bot pushed a commit that referenced this issue Oct 18, 2023
@gotmax23 @patchback
pr_labeler: stop adding new_triage labels to new PRs (#643)
2970754 
Fixes: #628
(cherry picked from commit e43d253)
@patchback patchback bot mentioned this issue Oct 18, 2023
Merged
patchback bot pushed a commit that referenced this issue Oct 18, 2023
@gotmax23 @patchback
pr_labeler: stop adding new_triage labels to new PRs (#643)
4e75788 
Fixes: #628
(cherry picked from commit e43d253)
@patchback patchback bot mentioned this issue Oct 18, 2023
Merged
patchback bot pushed a commit that referenced this issue Oct 18, 2023
@gotmax23 @patchback
pr_labeler: stop adding new_triage labels to new PRs (#643)
4b4ae7b 
Fixes: #628
(cherry picked from commit e43d253)
@patchback patchback bot mentioned this issue Oct 18, 2023
Merged
patchback bot pushed a commit that referenced this issue Oct 18, 2023
@gotmax23 @patchback
pr_labeler: stop adding new_triage labels to new PRs (#643)
736ae61 
Fixes: #628
(cherry picked from commit e43d253)
@patchback patchback bot mentioned this issue Oct 18, 2023
Merged
gotmax23 added a commit that referenced this issue Oct 18, 2023
@patchback @gotmax23
pr_labeler: stop adding needs_triage labels to new PRs (#643) (#648)
0aaa700 
(cherry picked from commit e43d253)

Fixes: #628
Co-authored-by: Maxwell G <[email protected]>
gotmax23 added a commit that referenced this issue Oct 18, 2023
@patchback @gotmax23
pr_labeler: stop adding needs_triage labels to new PRs (#643) (#645)
cd3d280 
(cherry picked from commit e43d253)

Fixes: #628
Co-authored-by: Maxwell G <[email protected]>
gotmax23 added a commit that referenced this issue Oct 18, 2023
@patchback @gotmax23
pr_labeler: stop adding needs_triage labels to new PRs (#643) (#646)
00034b1 
(cherry picked from commit e43d253)

Fixes: #628
Co-authored-by: Maxwell G <[email protected]>
gotmax23 added a commit that referenced this issue Oct 18, 2023
@patchback @gotmax23
pr_labeler: stop adding needs_triage labels to new PRs (#643) (#647)
f06c872 
(cherry picked from commit e43d253)

Fixes: #628
Co-authored-by: Maxwell G <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gotmax23 gotmax23

Labels
pr_labeler Issue or PR in the pr_labeler triager bot tooling This PR affects tooling (CI, pr_labeler, noxfile, linters, etc.) but not the docs builds themselves.
Projects
Ansible Documentation
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pr_labeler: stop adding needs_triage labels to new PRs gotmax23/ansible-documentation
3 participants
@gotmax23 @samccann @oraNod