Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pip-compile session to Python 3.11 #1614

Closed
oraNod opened this issue Jun 18, 2024 · 2 comments · Fixed by #1616
Closed

Bump pip-compile session to Python 3.11 #1614

oraNod opened this issue Jun 18, 2024 · 2 comments · Fixed by #1616
Labels
tooling This PR affects tooling (CI, pr_labeler, noxfile, linters, etc.) but not the docs builds themselves.

Comments

@oraNod
Copy link
Contributor

oraNod commented Jun 18, 2024

Ansible core dropped support for Python 3.10 with ansible/ansible@b2a289d

Given that docs are built on the core repo using Python 3.10 causes a failure when the build calls in to hacking/build-ansible.py. This change might warrant bumping the Python version that we use to pip compile project dependencies to be inline with the minimum supported version for core devel.

Potential changes to these files:

@oraNod oraNod added the tooling This PR affects tooling (CI, pr_labeler, noxfile, linters, etc.) but not the docs builds themselves. label Jun 18, 2024
@oraNod oraNod added the DaWGs Good discussion item for the DaWGs label Jun 18, 2024
@ansible-documentation-bot ansible-documentation-bot bot added the needs_triage Needs a first human triage before being processed. label Jun 18, 2024
@oraNod
Copy link
Contributor Author

oraNod commented Jun 19, 2024

@gotmax23 @felixfontein @webknjaz Hi! Can you please take a look at this and provide your thoughts and input?

I would like to do two things:

  1. Determine if we should bump to Python 3.11 for pip-compile sessions on the devel branch to match core.
  2. Capture details about the various Python versions in the noxfile and workflows in the README.

I do recall some discussion about the Python versions but the rationale behind them doesn't seem to be captured, even though we call out 3.10 in the README: https://github.com/ansible/ansible-documentation/blob/devel/README.md#updating-dependencies

Here is the issue where we added the noxfile for reference: #54

gotmax23 added a commit to gotmax23/ansible-documentation that referenced this issue Jun 19, 2024
This adjusts the devel branch to use Python 3.11 to generate
dependencies with pip-compile. This also adjusts the pip-compile-dev
workflow to run separate jobs for the stable branches. It's not a very
DRY approach; Github Actions does not support loops.

Fixes: ansible#1614
Fixes: ansible#1450
gotmax23 added a commit to gotmax23/ansible-documentation that referenced this issue Jun 19, 2024
This adjusts the devel branch to use Python 3.11 to generate
dependencies with pip-compile. This also adjusts the pip-compile-dev
workflow to run separate jobs for the stable branches, which will still
use Python 3.10 for requirements files. It's not a very
DRY approach; Github Actions does not support loops.

Fixes: ansible#1614
Fixes: ansible#1450
@x1101
Copy link
Contributor

x1101 commented Jun 30, 2024

Doesn't this also make make #1252 redundant? I've been digging through for tools related issues to pick up, and both this reads to me like a superset of what we were looking at for that one.

@samccann samccann removed the DaWGs Good discussion item for the DaWGs label Jul 9, 2024
@samccann samccann removed the needs_triage Needs a first human triage before being processed. label Jul 16, 2024
gotmax23 added a commit that referenced this issue Aug 13, 2024
This adjusts the devel branch to use Python 3.11 to generate
dependencies with pip-compile. This also adjusts the pip-compile-dev
workflow to run separate jobs for the stable branches, which will still
use Python 3.10 for requirements files.

Fixes: #1614
Fixes: #1450
gotmax23 added a commit that referenced this issue Aug 13, 2024
This adjusts the devel branch to use Python 3.11 to generate
dependencies with pip-compile. This also adjusts the pip-compile-dev
workflow to run separate jobs for the stable branches, which will still
use Python 3.10 for requirements files.

Fixes: #1614
Fixes: #1450
gotmax23 added a commit to gotmax23/ansible-documentation that referenced this issue Aug 13, 2024
This adjusts the devel branch to use Python 3.11 to generate
dependencies with pip-compile. This also adjusts the pip-compile-dev
workflow to run separate jobs for the stable branches, which will still
use Python 3.10 for requirements files.

Fixes: ansible#1614
Fixes: ansible#1450
@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in Ansible Documentation Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling This PR affects tooling (CI, pr_labeler, noxfile, linters, etc.) but not the docs builds themselves.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants