Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task as function in main.yaml #131

Closed
wants to merge 2 commits into from
Closed

task as function in main.yaml #131

wants to merge 2 commits into from

Conversation

trishnaguha
Copy link
Member

@trishnaguha trishnaguha commented Aug 9, 2018 •
edited
Loading

Signed-off-by: Trishna Guha [email protected]
Task as function in main.yaml entrypoint so the generic validations can run for tasks.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@trishnaguha trishnaguha force-pushed the task_as_function branch 2 times, most recently from 463d175 to d5181f8 Compare August 9, 2018 06:28
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@trishnaguha trishnaguha changed the title task as function, make main.yaml entrypoint task as function in main.yaml Aug 9, 2018
@trishnaguha trishnaguha mentioned this pull request Aug 9, 2018
Merged
@trishnaguha
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

gundalow
gundalow reviewed Aug 9, 2018
View reviewed changes
tasks/main.yml Outdated
include_tasks: "{{ function }}.yaml"
when: function is defined

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line too fix CI

ERROR: Found 1 yamllint issue(s) which need to be resolved:
ERROR: role-to-test/tasks/main.yml:17:1: empty-lines too many blank lines (1 > 0)

@trishnaguha
CI fix
94f65b9 
Signed-off-by: Trishna Guha <[email protected]>
@trishnaguha trishnaguha deleted the task_as_function branch August 13, 2018 10:47
@trishnaguha trishnaguha restored the task_as_function branch August 13, 2018 10:48
@trishnaguha trishnaguha reopened this Aug 13, 2018
@trishnaguha
Copy link
Member Author

recheck

@trishnaguha trishnaguha reopened this Aug 13, 2018
@trishnaguha trishnaguha deleted the task_as_function branch August 13, 2018 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gundalow gundalow gundalow left review comments

@privateip privateip Awaiting requested review from privateip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trishnaguha @gundalow