Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable keycloak_no_log controls ansible no_log parameter (for debugging purposes) #47

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Variable keycloak_no_log controls ansible no_log parameter (for debugging purposes) #47

merged 1 commit into from
Dec 15, 2022

Conversation

rpelisse
Copy link
Contributor

@rpelisse rpelisse commented Dec 15, 2022 •
edited by guidograzioli
Loading

New variable keycloak_no_log (default: true) changes the behavior for no_log ansible parameter for debugging purpose. Turning to false allows ansible-playbook execution to output clear text credentials

@rpelisse rpelisse added the minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix label Dec 15, 2022
@rpelisse rpelisse self-assigned this Dec 15, 2022
@rpelisse rpelisse marked this pull request as draft December 15, 2022 11:08
guidograzioli
guidograzioli reviewed Dec 15, 2022
View reviewed changes
Copy link
Member

@guidograzioli guidograzioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but pls set the default value to True and add a line in README with the new variable

roles/keycloak/meta/argument_specs.yml Outdated Show resolved Hide resolved
roles/keycloak/defaults/main.yml Outdated Show resolved Hide resolved
@rpelisse
Copy link
Contributor Author

I actually meant to set it to True 🤦 ... I hate boolean logic. (fixed)

@rpelisse rpelisse marked this pull request as ready for review December 15, 2022 13:40
@guidograzioli guidograzioli merged commit e17fda2 into main Dec 15, 2022
@guidograzioli guidograzioli changed the title allows user to switch no_log to True for debugging purpose Allow user to switch no_log to True for debugging purpose Dec 15, 2022
@guidograzioli guidograzioli changed the title Allow user to switch no_log to True for debugging purpose Variable keycloak_no_log controls behaviour of ansible no_log for debugging purpose Dec 15, 2022
@guidograzioli guidograzioli changed the title Variable keycloak_no_log controls behaviour of ansible no_log for debugging purpose Variable keycloak_no_log controls of ansible no_log (for debugging purposes) Dec 15, 2022
@guidograzioli guidograzioli changed the title Variable keycloak_no_log controls of ansible no_log (for debugging purposes) Variable keycloak_no_log controls ansible no_log parameter (for debugging purposes) Dec 15, 2022
@guidograzioli guidograzioli deleted the no_log branch April 18, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidograzioli guidograzioli guidograzioli left review comments

Assignees

@rpelisse rpelisse

Labels
minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpelisse @guidograzioli